Bug 1512517 - update WebRTC stat deprecation messages r=jib
authorNico Grunbaum <na-g@nostrum.com>
Thu, 06 Dec 2018 21:48:31 +0000
changeset 508798 6725a7f43baed5fb99ea7007c7df6147a94a419c
parent 508797 7f908c15daf69ea33ab6c71471f98a517e831f72
child 508799 d8e07613f15e55f43d654af8708ffa0cba1710d1
child 508808 e766954700c7e9999d199bfa522afa3617f03d21
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1512517
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1512517 - update WebRTC stat deprecation messages r=jib Update WebRTC stat deprecation messages which were originally targeting 65, which are now targeting 66. Differential Revision: https://phabricator.services.mozilla.com/D13950
dom/media/PeerConnection.js
--- a/dom/media/PeerConnection.js
+++ b/dom/media/PeerConnection.js
@@ -294,17 +294,17 @@ class RTCStatsReport {
 
   // TODO: Remove legacy API eventually
   // see Bug 1328194
   //
   // Since maplike is recent, we still also make the stats available as legacy
   // enumerable read-only properties directly on our content-facing object.
   //
   // In addition, we warn on iteration over isRemote:true entries, which is set
-  // to break in Firefox 65.
+  // to break in Firefox 66.
   //
   // Must be called after our webidl sandwich is made.
 
   makeStatsPublic(warnNullable, warnRemoteNullable, isLegacy) {
     let legacyProps = {};
     for (let key in this._report) {
       const underlying = this._report[key];
       // Add legacy names for renamed stats
@@ -533,26 +533,26 @@ class RTCPeerConnection {
     this._pc = new this._win.PeerConnectionImpl();
     this._operationsChain = this._win.Promise.resolve();
 
     this.__DOM_IMPL__._innerObject = this;
     this._observer = new this._win.PeerConnectionObserver(this.__DOM_IMPL__);
 
     // Warn just once per PeerConnection about deprecated getStats usage.
     this._warnDeprecatedStatsAccessNullable = { warn: () =>
-      this.logWarning("non-maplike pc.getStats access is deprecated, and will be removed in the near future! " +
+      this.logWarning("non-maplike pc.getStats access is deprecated, and will be removed in Firefox 66! " +
                       "See http://w3c.github.io/webrtc-pc/#getstats-example for usage.") };
 
     this._warnDeprecatedStatsCallbacksNullable = { warn: () =>
-      this.logWarning("Callback-based pc.getStats is deprecated, and will be removed in the near future! Use promise-version! " +
+      this.logWarning("Callback-based pc.getStats is deprecated, and will be removed in Firefox 66! Use promise-version! " +
                       "See http://w3c.github.io/webrtc-pc/#getstats-example for usage.") };
 
     this._warnDeprecatedStatsRemoteAccessNullable = { warn: (key) =>
-      this.logWarning(`Detected soon-to-break getStats() use with key="${key}"! stat.isRemote goes away in Firefox 65, but won't warn there!\
- - See https://blog.mozilla.org/webrtc/getstats-isremote-65/`) };
+      this.logWarning(`Detected soon-to-break getStats() use with key="${key}"! stat.isRemote goes away in Firefox 66, but won't warn there!\
+ - See https://blog.mozilla.org/webrtc/getstats-isremote-66/`) };
 
     // Add a reference to the PeerConnection to global list (before init).
     _globalPCList.addPC(this);
 
     this._impl.initialize(this._observer, this._win, rtcConfig,
                           Services.tm.currentThread);
 
     this._certificateReady = this._initCertificate(rtcConfig.certificates);