Bug 1543350 - don't shut-down taskqueue early. r=jya,mjf a=pascalc
authorAlex Chronopoulos <achronop@gmail.com>
Thu, 18 Apr 2019 08:23:59 +0000
changeset 526361 66d938a1a824b2bc26bebbf675124fa8275cffe9
parent 526360 b5794f0035103a7f991c3475b198541b7a22c0bd
child 526362 9fa4cf7dfb75f9591fd91a76776221af0868a995
push id2032
push userffxbld-merge
push dateMon, 13 May 2019 09:36:57 +0000
treeherdermozilla-release@455c1065dcbe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjya, mjf, pascalc
bugs1543350
milestone67.0
Bug 1543350 - don't shut-down taskqueue early. r=jya,mjf a=pascalc Shutting down the taskqueue early prevents the decoder's tasks to be queued. A TaskQueue no longer requires to be explicitly shutdown it will shutdown when ref counter drops to zero. Differential Revision: https://phabricator.services.mozilla.com/D26929
dom/media/ipc/RemoteDecoderParent.cpp
--- a/dom/media/ipc/RemoteDecoderParent.cpp
+++ b/dom/media/ipc/RemoteDecoderParent.cpp
@@ -153,19 +153,16 @@ mozilla::ipc::IPCResult RemoteDecoderPar
 
 void RemoteDecoderParent::ActorDestroy(ActorDestroyReason aWhy) {
   MOZ_ASSERT(!mDestroyed);
   MOZ_ASSERT(OnManagerThread());
   if (mDecoder) {
     mDecoder->Shutdown();
     mDecoder = nullptr;
   }
-  if (mDecodeTaskQueue) {
-    mDecodeTaskQueue->BeginShutdown();
-  }
 }
 
 void RemoteDecoderParent::Error(const MediaResult& aError) {
   MOZ_ASSERT(OnManagerThread());
   if (!mDestroyed) {
     Unused << SendError(aError);
   }
 }