Bug 1414838 - Show stop button again as soon as page loading starts. r=nechen a=sylvestre
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 06 Nov 2017 20:20:57 +0100
changeset 435366 665de5ab92fccb052ee1625e1df196c8a9d082d0
parent 435365 0fc25c29cbf8710b43be604024fd28c00e77a3ea
child 435367 7d0ce703edbb1ee38358ecfc5578281543570521
push id1587
push usersledru@mozilla.com
push dateThu, 23 Nov 2017 15:08:39 +0000
treeherdermozilla-release@c40c1a52ec1b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnechen, sylvestre
bugs1414838, 1366672
milestone57.0.1
Bug 1414838 - Show stop button again as soon as page loading starts. r=nechen a=sylvestre As of bug 1366672, case START no longer falls through in order to allow for a different behaviour of the progress indicator, however we still need to add UpdateFlags.PROGRESS, so that the stop button shows up as soon as a page starts loading. MozReview-Commit-ID: 3P33JEsS5ic
mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
--- a/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
+++ b/mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java
@@ -459,16 +459,17 @@ public abstract class BrowserToolbar ext
         }
 
         if (tabs.isSelectedTab(tab)) {
             final EnumSet<UpdateFlags> flags = EnumSet.noneOf(UpdateFlags.class);
 
             // Progress-related handling
             switch (msg) {
                 case START:
+                    flags.add(UpdateFlags.PROGRESS);
                     updateProgressVisibility(tab, Tab.LOAD_PROGRESS_INIT);
                     break;
                 case ADDED:
                 case LOCATION_CHANGE:
                 case LOAD_ERROR:
                 case LOADED:
                 case STOP:
                     flags.add(UpdateFlags.PROGRESS);