Bug 1520957 - [release 119] changing the position of cursor location and toggle button in the footer (#7684). r=dwalsh
☠☠ backed out by ef836f7dfc08 ☠ ☠
authorHet Patel <patel.het33@gmail.com>
Fri, 18 Jan 2019 12:06:24 -0500
changeset 514539 6371d4b4ff1ec1d79446f3c05898903a17ff41f7
parent 514538 862c4fc3b6abcf5094a00993f17331f04383bba0
child 514540 e281e4064349eb5bfc9ecf14e83153e7abbbd3ef
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdwalsh
bugs1520957
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1520957 - [release 119] changing the position of cursor location and toggle button in the footer (#7684). r=dwalsh
devtools/client/debugger/new/dist/debugger.css
devtools/client/debugger/new/src/components/Editor/Footer.css
devtools/client/debugger/new/src/components/Editor/Footer.js
devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
--- a/devtools/client/debugger/new/dist/debugger.css
+++ b/devtools/client/debugger/new/dist/debugger.css
@@ -2375,17 +2375,17 @@ menuseparator {
 .source-footer > .commands > .blackboxed > .img.blackBox {
   background: var(--theme-highlight-blue);
 }
 
 .source-footer .blackbox-summary,
 .source-footer .mapped-source,
 .source-footer .cursor-position {
   color: var(--theme-body-color);
-  padding-left: 2.5px;
+  padding-right: 2.5px;
 }
 
 .source-footer .mapped-source {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
 }
 
--- a/devtools/client/debugger/new/src/components/Editor/Footer.css
+++ b/devtools/client/debugger/new/src/components/Editor/Footer.css
@@ -81,17 +81,17 @@
 .source-footer > .commands > .blackboxed > .img.blackBox {
   background: var(--theme-highlight-blue);
 }
 
 .source-footer .blackbox-summary,
 .source-footer .mapped-source,
 .source-footer .cursor-position {
   color: var(--theme-body-color);
-  padding-left: 2.5px;
+  padding-right: 2.5px;
 }
 
 .source-footer .mapped-source {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
 }
 
--- a/devtools/client/debugger/new/src/components/Editor/Footer.js
+++ b/devtools/client/debugger/new/src/components/Editor/Footer.js
@@ -234,18 +234,18 @@ class SourceFooter extends PureComponent
     if (!shouldShowFooter(selectedSource, horizontal)) {
       return null;
     }
 
     return (
       <div className="source-footer">
         {this.renderCommands()}
         {this.renderSourceSummary()}
+        {this.renderCursorPosition()}
         {this.renderToggleButton()}
-        {this.renderCursorPosition()}
       </div>
     );
   }
 }
 
 const mapStateToProps = state => {
   const selectedSource = getSelectedSource(state);
 
--- a/devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
+++ b/devtools/client/debugger/new/src/components/Editor/tests/__snapshots__/Footer.spec.js.snap
@@ -1,39 +1,39 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`SourceFooter Component default case should render 1`] = `
 <div
   className="source-footer"
 >
+  <span
+    className="cursor-position"
+    title="(Line 2, column 2)"
+  >
+    (2, 2)
+  </span>
   <PaneToggleButton
     collapsed={true}
     horizontal={false}
     key="toggle"
     position="end"
   />
-  <span
-    className="cursor-position"
-    title="(Line 2, column 2)"
-  >
-    (2, 2)
-  </span>
 </div>
 `;
 
 exports[`SourceFooter Component move cursor should render new cursor position 1`] = `
 <div
   className="source-footer"
 >
+  <span
+    className="cursor-position"
+    title="(Line 6, column 11)"
+  >
+    (6, 11)
+  </span>
   <PaneToggleButton
     collapsed={true}
     horizontal={false}
     key="toggle"
     position="end"
   />
-  <span
-    className="cursor-position"
-    title="(Line 6, column 11)"
-  >
-    (6, 11)
-  </span>
 </div>
 `;