Bug 1561435 - Fix linting errors for image/, r=standard8
authorVictor Porof <vporof@mozilla.com>
Thu, 20 Jun 2019 11:03:45 -0700
changeset 544242 62a5aeaf0dffe36b7157d4efe10afd0ff8369026
parent 544241 bcb509a14173f2e859626bc4eeaeb63b13d5dc73
child 544243 928cc5362416f47d61bea6fc55965e5084b8204c
push id2131
push userffxbld-merge
push dateMon, 26 Aug 2019 18:30:20 +0000
treeherdermozilla-release@b19ffb3ca153 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstandard8
bugs1561435
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1561435 - Fix linting errors for image/, r=standard8 # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D35907
image/test/unit/test_encoder_apng.js
image/test/unit/test_encoder_png.js
image/test/unit/test_imgtools.js
--- a/image/test/unit/test_encoder_apng.js
+++ b/image/test/unit/test_encoder_apng.js
@@ -1059,16 +1059,17 @@ function makeDataURL(encoder, mimetype) 
 
   return "data:" + mimetype + ";base64," + base64String;
 }
 
 /* toBase64 copied from extensions/xml-rpc/src/nsXmlRpcClient.js */
 
 /* Convert data (an array of integers) to a Base64 string. */
 const toBase64Table =
+  // eslint-disable-next-line no-useless-concat
   "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" + "0123456789+/";
 const base64Pad = "=";
 function toBase64(data) {
   var result = "";
   var length = data.length;
   var i;
   // Convert every three bytes to 4 ascii characters.
   for (i = 0; i < length - 2; i += 3) {
--- a/image/test/unit/test_encoder_png.js
+++ b/image/test/unit/test_encoder_png.js
@@ -345,16 +345,17 @@ function makeDataURLFromAsync(encoder, m
   };
   rawStream.asyncWait(asyncReader, 0, 0, currentThread);
 }
 
 /* toBase64 copied from extensions/xml-rpc/src/nsXmlRpcClient.js */
 
 /* Convert data (an array of integers) to a Base64 string. */
 const toBase64Table =
+  // eslint-disable-next-line no-useless-concat
   "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz" + "0123456789+/";
 const base64Pad = "=";
 function toBase64(data) {
   var result = "";
   var length = data.length;
   var i;
   // Convert every three bytes to 4 ascii characters.
   for (i = 0; i < length - 2; i += 3) {
--- a/image/test/unit/test_imgtools.js
+++ b/image/test/unit/test_imgtools.js
@@ -362,16 +362,17 @@ function run_test() {
     referenceBytes = streamToArray(istream);
 
     // compare the encoder's output to the reference file.
     compareArrays(encodedBytes, referenceBytes);
 
     /* ========== 12 ========== */
     testnum++;
     testdesc =
+      // eslint-disable-next-line no-useless-concat
       "test encoding a scaled ICO with format options " + "(format=bmp;bpp=32)";
 
     // we'll reuse the container from the previous test
     istream = imgTools.encodeScaledImage(
       container,
       "image/vnd.microsoft.icon",
       16,
       16,
@@ -411,16 +412,17 @@ function run_test() {
     referenceBytes = streamToArray(istream);
 
     // compare the encoder's output to the reference file.
     compareArrays(encodedBytes, referenceBytes);
 
     /* ========== 14 ========== */
     testnum++;
     testdesc =
+      // eslint-disable-next-line no-useless-concat
       "test encoding a scaled ICO with format options " + "(format=bmp;bpp=24)";
 
     // we'll reuse the container from the previous test
     istream = imgTools.encodeScaledImage(
       container,
       "image/vnd.microsoft.icon",
       16,
       16,