Bug 1289001 - Remove the MOZ_NORETURN hint from CrashWithReason. r=valentin, a=bustage FIREFOX_51_0b2_BUILD1 FIREFOX_51_0b2_RELEASE
authorRyan VanderMeulen <ryanvm@gmail.com>
Mon, 21 Nov 2016 12:38:25 -0500
changeset 358906 6296ed3dbefd133bba324230ec4f5a07d37041e1
parent 358905 ed11e7d991e2a34d644bde0afc46e15d342ca09a
child 358907 5650168b1ca4efc51ee7ca345935bd2e1b00584f
push id1324
push usermtabara@mozilla.com
push dateMon, 16 Jan 2017 13:07:44 +0000
treeherdermozilla-release@a01c49833940 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvalentin, bustage
bugs1289001
milestone51.0
Bug 1289001 - Remove the MOZ_NORETURN hint from CrashWithReason. r=valentin, a=bustage
netwerk/ipc/NeckoParent.cpp
--- a/netwerk/ipc/NeckoParent.cpp
+++ b/netwerk/ipc/NeckoParent.cpp
@@ -151,17 +151,17 @@ GetRequestingPrincipal(const FTPChannelC
 
   const FTPChannelOpenArgs& args = aArgs.get_FTPChannelOpenArgs();
   return GetRequestingPrincipal(args.loadInfo());
 }
 
 // Bug 1289001 - If GetValidatedAppInfo returns an error string, that usually
 // leads to a content crash with very little info about the cause.
 // We prefer to crash on the parent, so we get the reason in the crash report.
-static MOZ_NORETURN MOZ_COLD
+static MOZ_COLD
 void CrashWithReason(const char * reason)
 {
 #ifndef RELEASE_BUILD
   MOZ_CRASH_ANNOTATE(reason);
   MOZ_REALLY_CRASH();
 #endif
 }