Bug 1519501 - Update min cbindgen version. r=dmajor
authorEmilio Cobos Álvarez <emilio@crisal.io>
Sun, 13 Jan 2019 00:42:35 +0100
changeset 513698 620e00a8a3ac5d3af4c003cadd6f7934a9271c94
parent 513697 2b2c8d1455411dcddd3e5fbb615af1d7efe4aa95
child 513699 8a7ab9b279fe0afa3d6ce49db711e41f022410a8
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1519501
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1519501 - Update min cbindgen version. r=dmajor We need this to properly generate the WR bindings. Also update the comment since the check was recently moved. Differential Revision: https://phabricator.services.mozilla.com/D16398
build/moz.configure/bindgen.configure
taskcluster/scripts/misc/build-cbindgen.sh
--- a/build/moz.configure/bindgen.configure
+++ b/build/moz.configure/bindgen.configure
@@ -9,17 +9,17 @@ cbindgen = check_prog('CBINDGEN', ['cbin
                       when=depends(build_project)
                       (lambda build_project: build_project != 'js'))
 
 
 @depends_if(cbindgen)
 @checking('cbindgen version')
 @imports(_from='textwrap', _import='dedent')
 def cbindgen_version(cbindgen):
-    cbindgen_min_version = Version('0.6.7')
+    cbindgen_min_version = Version('0.6.8')
 
     # cbindgen x.y.z
     version = Version(check_cmd_output(cbindgen, '--version').strip().split(" ")[1])
 
     if version < cbindgen_min_version:
         die(dedent('''\
         cbindgen version {} is too old. At least version {} is required.
 
--- a/taskcluster/scripts/misc/build-cbindgen.sh
+++ b/taskcluster/scripts/misc/build-cbindgen.sh
@@ -1,14 +1,14 @@
 #!/bin/bash
 set -x -e -v
 
 # If you update this, make sure to update the minimum version in
-# build/moz.configure/rust.configure as well.
-CBINDGEN_VERSION=v0.6.7
+# build/moz.configure/bindgen.configure as well.
+CBINDGEN_VERSION=v0.6.8
 TARGET="$1"
 
 case "$(uname -s)" in
 Linux)
     WORKSPACE=$HOME/workspace
     UPLOAD_DIR=$HOME/artifacts
     COMPRESS_EXT=xz
     ;;