Bug 1512706 - Update minidump_stackwalk used for tests. r+a=RyanVM
authorMike Hommey <mh+mozilla@glandium.org>
Mon, 10 Dec 2018 22:51:50 +0000
changeset 508973 60444ade289159d488b7ab144e28e7091946a43c
parent 508972 3a8a5011f5bf8bd3dcfe84af64c459fef20d49a2
child 508974 86e560ca1e292800a65bf10ad8ec446277c2b2ef
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1512706
milestone65.0
Bug 1512706 - Update minidump_stackwalk used for tests. r+a=RyanVM The minidump_stackwalk used for tests ifs picked up from tooltool, and it looks like the tooltool manifests haven't been updated in 2 years. As it turns out, this old version is not capable of, at least, stack walk over crashes originated in LTOed rust code on Windows, while breakpad trunk, as well as the slightly oldest version we have in-tree do. While ideally, we'd go with building minidump_stackwalk as a taskcluster toolchain artifact, or during the build, but that involves significantly more work, while we should fix the stack traces of crashes that people _do_ get as early as possible. The tooltool artifacts linked in the updated manifests were generated the following way: - Revert the last two changes that happened to minidump_stackwalk.cc between 2016 and now (they don't matter for functionality and get in the way of the rest below). - Apply the changes betwen the version of minidump_stackwalk.cc from 2016 and https://hg.mozilla.org/users/tmielczarek_mozilla.com/stackwalk-http/raw-file/51e4725ffad4/stackwalk.cc - Pick the http_symbol_supplier.cc and http_symbol_supplier.h files from the same repo as stackwalk.cc above. - Add the necessary build system bits to build it off the Gecko tree, along with the in-tree breakpad code. - Build it for linux, linux64, macosx64, win32-mingw. The patch doing all the above is: https://hg.mozilla.org/try/rev/64491336dc7fca7a1c00ae8c66619b01563bbe4e The push to build it on the aforementioned platforms: https://hg.mozilla.org/try/rev/4b621a67ca0bd6cf8954566e180d23e1ba8a9f83 A win64-mingw variant was also built, but is not being used, keeping things in line with what we currently are using. We may want to follow up with an update to use that win64 variant on 64-bits testers. Differential Revision: https://phabricator.services.mozilla.com/D14005
browser/config/tooltool-manifests/win32/releng.manifest
browser/config/tooltool-manifests/win64/aarch64.manifest
browser/config/tooltool-manifests/win64/releng.manifest
testing/config/tooltool-manifests/linux32/releng.manifest
testing/config/tooltool-manifests/linux64/releng.manifest
testing/config/tooltool-manifests/macosx64/releng.manifest
testing/config/tooltool-manifests/win32/releng.manifest
--- a/browser/config/tooltool-manifests/win32/releng.manifest
+++ b/browser/config/tooltool-manifests/win32/releng.manifest
@@ -18,15 +18,15 @@
     "algorithm": "sha512",
     "visibility": "public",
     "filename": "makecab.tar.bz2",
     "unpack": true,
     "digest": "196ac6a567c85559957dfe511c3d8654d23c94d5603259e19ccafe9d71e0e4ccee63ccc9a778f2699654b786cda54266108b7d4db543d01bb0b42545b4e6ec75",
     "size": 297118
   },
   {
-    "size": 1516544,
+    "size": 1701376,
     "visibility": "public",
-    "digest": "cf84f9592059f1e0756370f44e0ad289b71569c235d2ec8c5958695cc57352d3b99b584fd119e73fc9593d1c4cca414985e71f567f777162471b6040ebc59d13",
+    "digest": "2bc729f9cedfba59b5c7a088f00d00fc078af3bd08e88ee41bbb1ea092038466f46589cef036e0d928249f6037fb22828f62e6d82a32d018f66ca92a834393c8",
     "algorithm": "sha512",
     "filename": "win32-minidump_stackwalk.exe"
   }
 ]
--- a/browser/config/tooltool-manifests/win64/aarch64.manifest
+++ b/browser/config/tooltool-manifests/win64/aarch64.manifest
@@ -19,15 +19,15 @@
     "algorithm": "sha512",
     "visibility": "public",
     "filename": "makecab.tar.bz2",
     "unpack": true,
     "digest": "196ac6a567c85559957dfe511c3d8654d23c94d5603259e19ccafe9d71e0e4ccee63ccc9a778f2699654b786cda54266108b7d4db543d01bb0b42545b4e6ec75",
     "size": 297118
   },
   {
-    "size": 1516544,
+    "size": 1701376,
     "visibility": "public",
-    "digest": "cf84f9592059f1e0756370f44e0ad289b71569c235d2ec8c5958695cc57352d3b99b584fd119e73fc9593d1c4cca414985e71f567f777162471b6040ebc59d13",
+    "digest": "2bc729f9cedfba59b5c7a088f00d00fc078af3bd08e88ee41bbb1ea092038466f46589cef036e0d928249f6037fb22828f62e6d82a32d018f66ca92a834393c8",
     "algorithm": "sha512",
     "filename": "win32-minidump_stackwalk.exe"
   }
 ]
--- a/browser/config/tooltool-manifests/win64/releng.manifest
+++ b/browser/config/tooltool-manifests/win64/releng.manifest
@@ -18,15 +18,15 @@
     "algorithm": "sha512",
     "visibility": "public",
     "filename": "makecab.tar.bz2",
     "unpack": true,
     "digest": "196ac6a567c85559957dfe511c3d8654d23c94d5603259e19ccafe9d71e0e4ccee63ccc9a778f2699654b786cda54266108b7d4db543d01bb0b42545b4e6ec75",
     "size": 297118
   },
   {
-    "size": 1516544,
+    "size": 1701376,
     "visibility": "public",
-    "digest": "cf84f9592059f1e0756370f44e0ad289b71569c235d2ec8c5958695cc57352d3b99b584fd119e73fc9593d1c4cca414985e71f567f777162471b6040ebc59d13",
+    "digest": "2bc729f9cedfba59b5c7a088f00d00fc078af3bd08e88ee41bbb1ea092038466f46589cef036e0d928249f6037fb22828f62e6d82a32d018f66ca92a834393c8",
     "algorithm": "sha512",
     "filename": "win32-minidump_stackwalk.exe"
   }
 ]
--- a/testing/config/tooltool-manifests/linux32/releng.manifest
+++ b/testing/config/tooltool-manifests/linux32/releng.manifest
@@ -1,9 +1,9 @@
 [
   {
-    "size": 1845800,
+    "size": 866276,
     "visibility": "public",
-    "digest": "70cf423b4cc04c2a7bdb50b802e2528d517c5c5192cd94b729e7b07fc5e943c709bed2357287b5388a5332b7be31b13a0d334fded6ae7c36c12ceda1710b901a",
+    "digest": "a063a151555ef78f8d5795f558632dd7d3f511ad6276915f3c8cfec44146ba1e82c0a3db063a3e30921171563880d4d7794da1a036b00fab03d95988d491dc6b",
     "algorithm": "sha512",
     "filename": "linux32-minidump_stackwalk"
   }
 ]
--- a/testing/config/tooltool-manifests/linux64/releng.manifest
+++ b/testing/config/tooltool-manifests/linux64/releng.manifest
@@ -1,9 +1,9 @@
 [
   {
-    "size": 1737944,
+    "size": 868232,
     "visibility": "public",
-    "digest": "76d704f0bfa110f5ea298b87200e34ec09d039b9d1a59ec819fc8e02b2cf073af32a4536dca33a3813f037a557fd0669b48a063c7a920f6308b307148029d41f",
+    "digest": "feef6f28d74ddbefe69ec7be5fb5fcac8b6d5ab302f6773911f69fd27875b709c42e8001737fbff831984917d30c5d8b8e7511b25a60865da5cc00e34b6504d9",
     "algorithm": "sha512",
     "filename": "linux64-minidump_stackwalk"
   }
 ]
--- a/testing/config/tooltool-manifests/macosx64/releng.manifest
+++ b/testing/config/tooltool-manifests/macosx64/releng.manifest
@@ -1,9 +1,9 @@
 [
   {
-    "size": 862324,
+    "size": 843008,
     "visibility": "public",
-    "digest": "681cf3906b294c05bdc3271e3fad0f964372a3208dc42e0fea032d194cb480239e32a5cb898d2297614c9a55afe9aa9e06797e52c8c775c67b6c4e09396b957b",
+    "digest": "2105e384ffbf3459d91701207e879a676ab8e49ca1dc2b7bf1e7d695fb6245ba719285c9841429bbc6605ae4e710107621f788a7204ed681148115ccf64ac087",
     "algorithm": "sha512",
     "filename": "macosx64-minidump_stackwalk"
   }
 ]
--- a/testing/config/tooltool-manifests/win32/releng.manifest
+++ b/testing/config/tooltool-manifests/win32/releng.manifest
@@ -1,9 +1,9 @@
 [
   {
-    "size": 1516544,
+    "size": 1701376,
     "visibility": "public",
-    "digest": "cf84f9592059f1e0756370f44e0ad289b71569c235d2ec8c5958695cc57352d3b99b584fd119e73fc9593d1c4cca414985e71f567f777162471b6040ebc59d13",
+    "digest": "2bc729f9cedfba59b5c7a088f00d00fc078af3bd08e88ee41bbb1ea092038466f46589cef036e0d928249f6037fb22828f62e6d82a32d018f66ca92a834393c8",
     "algorithm": "sha512",
     "filename": "win32-minidump_stackwalk.exe"
   }
 ]