Bug 1290015 - [Static Analysis][Uninitialized scalar field] In constructor SizeSpec(). r=jst
authorPaul Bignier <paul.bignier@gmail.com>
Thu, 28 Jul 2016 01:25:00 +0200
changeset 349366 6010b7802ecb04364a553bff1c4bc2ffde6d8326
parent 349365 3f06b617447c62efd2723fba2d99ec6bacc1e126
child 349367 22b93575a3d939787576df00ac185a8e1ece3e17
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjst
bugs1290015
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1290015 - [Static Analysis][Uninitialized scalar field] In constructor SizeSpec(). r=jst
embedding/components/windowwatcher/nsWindowWatcher.cpp
--- a/embedding/components/windowwatcher/nsWindowWatcher.cpp
+++ b/embedding/components/windowwatcher/nsWindowWatcher.cpp
@@ -373,17 +373,23 @@ nsWindowWatcher::OpenWindow(mozIDOMWindo
                             /* calledFromJS = */ false, dialog,
                             /* navigate = */ true, argv,
                             /* openerFullZoom = */ nullptr, aResult);
 }
 
 struct SizeSpec
 {
   SizeSpec()
-    : mLeftSpecified(false)
+    : mLeft(0)
+    , mTop(0)
+    , mOuterWidth(0)
+    , mOuterHeight(0)
+    , mInnerWidth(0)
+    , mInnerHeight(0)
+    , mLeftSpecified(false)
     , mTopSpecified(false)
     , mOuterWidthSpecified(false)
     , mOuterHeightSpecified(false)
     , mInnerWidthSpecified(false)
     , mInnerHeightSpecified(false)
     , mUseDefaultWidth(false)
     , mUseDefaultHeight(false)
   {