Bug 1526861 - Incorrect numbers listed for numbered list sections. r=Mardak a=lizzard
authork88hudson <k88hudson@gmail.com>
Sat, 16 Feb 2019 00:49:24 +0200
changeset 515988 5d44e50ff0c250f05778c896e2f00387f51b0fe6
parent 515987 3c371055b3815f02899b6a5055496d29e35f79b6
child 515989 d5494d3885c75f0bdde1d08932439961f5300e0e
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMardak, lizzard
bugs1526861
milestone66.0
Bug 1526861 - Incorrect numbers listed for numbered list sections. r=Mardak a=lizzard Reviewers: Mardak Reviewed By: Mardak Bug #: 1526861 Differential Revision: https://phabricator.services.mozilla.com/D19718
browser/components/newtab/content-src/components/DiscoveryStreamComponents/List/List.jsx
browser/components/newtab/data/content/activity-stream.bundle.js
--- a/browser/components/newtab/content-src/components/DiscoveryStreamComponents/List/List.jsx
+++ b/browser/components/newtab/content-src/components/DiscoveryStreamComponents/List/List.jsx
@@ -27,36 +27,36 @@ export class ListItem extends React.Pure
         click: 0,
         tiles: [{id: this.props.id, pos: this.props.index}],
       }));
     }
   }
 
   render() {
     return (
-      <SpocIntersectionObserver campaignId={this.props.campaignId} dispatch={this.props.dispatch}>
-        <li className="ds-list-item">
+      <li className="ds-list-item">
+        <SpocIntersectionObserver campaignId={this.props.campaignId} dispatch={this.props.dispatch}>
           <a className="ds-list-item-link" href={this.props.url} onClick={this.onLinkClick}>
             <div className="ds-list-item-text">
               <div className="ds-list-item-title">{this.props.title}</div>
               {this.props.excerpt && <div className="ds-list-item-excerpt">{this.props.excerpt}</div>}
               <p>
                 {this.props.context && (
                   <span>
                     <span className="ds-list-item-context">{this.props.context}</span>
                     <br />
                   </span>
                 )}
                 <span className="ds-list-item-info">{this.props.domain}</span>
               </p>
             </div>
             <div className="ds-list-image" style={{backgroundImage: `url(${this.props.image_src})`}} />
           </a>
-        </li>
-      </SpocIntersectionObserver>
+        </SpocIntersectionObserver>
+      </li>
     );
   }
 }
 
 /**
  * @note exported for testing only
  */
 export function _List(props) {
--- a/browser/components/newtab/data/content/activity-stream.bundle.js
+++ b/browser/components/newtab/data/content/activity-stream.bundle.js
@@ -7326,21 +7326,21 @@ class List_ListItem extends external_Rea
         click: 0,
         tiles: [{ id: this.props.id, pos: this.props.index }]
       }));
     }
   }
 
   render() {
     return external_React_default.a.createElement(
-      SpocIntersectionObserver["SpocIntersectionObserver"],
-      { campaignId: this.props.campaignId, dispatch: this.props.dispatch },
+      "li",
+      { className: "ds-list-item" },
       external_React_default.a.createElement(
-        "li",
-        { className: "ds-list-item" },
+        SpocIntersectionObserver["SpocIntersectionObserver"],
+        { campaignId: this.props.campaignId, dispatch: this.props.dispatch },
         external_React_default.a.createElement(
           "a",
           { className: "ds-list-item-link", href: this.props.url, onClick: this.onLinkClick },
           external_React_default.a.createElement(
             "div",
             { className: "ds-list-item-text" },
             external_React_default.a.createElement(
               "div",