Bug 1507157 - Set network.disable.ipc.security to true. r=kershaw, a=RyanVM
authorValentin Gosu <valentin.gosu@gmail.com>
Mon, 19 Nov 2018 15:41:57 +0000
changeset 501373 5cb26828de28e16dbd8e4cc61a13d3d4dd62507f
parent 501372 fdd0d5ac1d28020c16b5da499d5e65441c4e1f09
child 501374 20620b54cc8cb5bf7f4c346ee7973698230450cd
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskershaw, RyanVM
bugs1507157, 1306801
milestone64.0
Bug 1507157 - Set network.disable.ipc.security to true. r=kershaw, a=RyanVM This pref is left over from B2G days. It is currently disabled for firefox desktop, but not for Android. This didn't affect us until now because we always ran Android tests in non-e10s mode. The pref ought to be removed in bug 1306801. Differential Revision: https://phabricator.services.mozilla.com/D12293
browser/app/profile/firefox.js
modules/libpref/init/all.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1374,20 +1374,16 @@ pref("geo.provider.ms-windows-location",
 #endif
 
 #if defined(MOZ_WIDGET_GTK) && defined(MOZ_GPSD)
 pref("geo.provider.use_gpsd", true);
 #endif
 
 #endif
 
-// Necko IPC security checks only needed for app isolation for cookies/cache/etc:
-// currently irrelevant for desktop e10s
-pref("network.disable.ipc.security", true);
-
 // CustomizableUI debug logging.
 pref("browser.uiCustomization.debug", false);
 
 // CustomizableUI state of the browser's user interface
 pref("browser.uiCustomization.state", "");
 
 // If set to false, FxAccounts and Sync will be unavailable.
 // A restart is mandatory after flipping that preference.
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -1577,17 +1577,17 @@ pref("network.notify.IPv6", true);
 
 // Transmit UDP busy-work to the LAN when anticipating low latency
 // network reads and on wifi to mitigate 802.11 Power Save Polling delays
 pref("network.tickle-wifi.enabled", false);
 pref("network.tickle-wifi.duration", 400);
 pref("network.tickle-wifi.delay", 16);
 
 // Turn off interprocess security checks. Needed to run xpcshell tests.
-pref("network.disable.ipc.security", false);
+pref("network.disable.ipc.security", true);
 
 // Default action for unlisted external protocol handlers
 pref("network.protocol-handler.external-default", true);      // OK to load
 pref("network.protocol-handler.warn-external-default", true); // warn before load
 
 // Prevent using external protocol handlers for these schemes
 pref("network.protocol-handler.external.hcp", false);
 pref("network.protocol-handler.external.vbscript", false);