Bug 1574126 [wpt PR 18454] - [Azure Pipelines] drop old workaround for `safaridriver --version`, a=testonly
authorPhilip Jägenstedt <philip@foolip.org>
Mon, 26 Aug 2019 11:26:57 +0000
changeset 553947 5bdb6f1e8f37dfdc0ca96fdb8ae79ea0a36f2483
parent 553946 bff8292409ef3d02dff5515ced4ae1bb976fc58d
child 553948 c54a17c0f130def375ddf9dffae7b4ebd52d9da0
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1574126, 18454
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1574126 [wpt PR 18454] - [Azure Pipelines] drop old workaround for `safaridriver --version`, a=testonly Automatic update from web-platform-tests [Azure Pipelines] drop old workaround for `safaridriver --version` (#18454) The `--version` argument is supported starting in Safari 12.1: https://github.com/web-platform-tests/results-collection/issues/617 -- wpt-commits: a2d1acf3d4e8fe76eba70ee9b5f69dba2189819f wpt-pr: 18454
testing/web-platform/tests/.azure-pipelines.yml
--- a/testing/web-platform/tests/.azure-pipelines.yml
+++ b/testing/web-platform/tests/.azure-pipelines.yml
@@ -329,20 +329,17 @@ jobs:
       packages: virtualenv
   - template: tools/ci/azure/install_fonts.yml
   - template: tools/ci/azure/install_certs.yml
   - template: tools/ci/azure/install_safari.yml
     parameters:
       channel: stable
   - template: tools/ci/azure/update_hosts.yml
   - template: tools/ci/azure/update_manifest.yml
-  - script: |
-      # TODO: drop this when `safaridriver --version` is supported.
-      SAFARI_VERSION="$(/usr/libexec/PlistBuddy -c 'Print :CFBundleShortVersionString' /Applications/Safari.app/Contents/Info.plist) ($(/usr/libexec/PlistBuddy -c 'Print :CFBundleVersion' /Applications/Safari.app/Contents/Info.plist))"
-      no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info --browser-version "$SAFARI_VERSION" safari
+  - script: no_proxy='*' ./wpt run --no-manifest-update --no-restart-on-unexpected --no-fail-on-unexpected --this-chunk=$(System.JobPositionInPhase) --total-chunks=$(System.TotalJobsInPhase) --chunk-type hash --log-wptreport $(Build.ArtifactStagingDirectory)/wpt_report_$(System.JobPositionInPhase).json --log-wptscreenshot $(Build.ArtifactStagingDirectory)/wpt_screenshot_$(System.JobPositionInPhase).txt --log-tbpl - --log-tbpl-level info safari
     displayName: 'Run tests'
   - task: PublishBuildArtifacts@1
     displayName: 'Publish results'
     inputs:
       artifactName: 'safari-results'
 - template: tools/ci/azure/fyi_hook.yml
   parameters:
     dependsOn: results_safari