Backed out changeset 120a4d4dced8 (bug 1467679) for Devtools failure on devtools/client/debugger/test/mochitest/browser_dbg_host-layout.js. CLOSED TREE
authorDorel Luca <dluca@mozilla.com>
Fri, 08 Jun 2018 19:33:15 +0300
changeset 478746 5a6ef0a517fa09802f7fd92df34488b3cd51f760
parent 478745 41d517d39bdd5070f84be8c8b8002b3944d5928e
child 478747 43bd7e809560b7866ca9b253ce660e17c5f010ea
push id1757
push userffxbld-merge
push dateFri, 24 Aug 2018 17:02:43 +0000
treeherdermozilla-release@736023aebdb1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1467679
milestone62.0a1
backs out120a4d4dced81e390d3d25dba18004ad8a0a544d
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 120a4d4dced8 (bug 1467679) for Devtools failure on devtools/client/debugger/test/mochitest/browser_dbg_host-layout.js. CLOSED TREE
devtools/client/framework/toolbox-host-manager.js
devtools/client/framework/toolbox-hosts.js
--- a/devtools/client/framework/toolbox-host-manager.js
+++ b/devtools/client/framework/toolbox-host-manager.js
@@ -39,21 +39,16 @@ let ID_COUNTER = 1;
 
 function ToolboxHostManager(target, hostType, hostOptions) {
   this.target = target;
 
   this.frameId = ID_COUNTER++;
 
   if (!hostType) {
     hostType = Services.prefs.getCharPref(LAST_HOST);
-    if (!Hosts[hostType]) {
-      // If the preference value is unexpected, restore to the default value.
-      Services.prefs.clearUserPref(LAST_HOST);
-      hostType = Services.prefs.getCharPref(LAST_HOST);
-    }
   }
   this.host = this.createHost(hostType, hostOptions);
   this.hostType = hostType;
 }
 
 ToolboxHostManager.prototype = {
   async create(toolId) {
     await this.host.create();
--- a/devtools/client/framework/toolbox-hosts.js
+++ b/devtools/client/framework/toolbox-hosts.js
@@ -121,17 +121,17 @@ BottomHost.prototype = {
 };
 
 /**
  * Base Host object for the in-browser sidebar
  */
 class SidebarHost {
   constructor(hostTab, hostType) {
     this.hostTab = hostTab;
-    this.hostType = hostType;
+    this.type = hostType;
     this.widthPref = "devtools.toolbox.sidebar.width";
 
     EventEmitter.decorate(this);
   }
 
   /**
    * Create a box in the sidebar of the host tab.
    */