Bug 1437345 - Set defaults for gn visual studio build; r=jesup a=NPOTB
authorDan Minor <dminor@mozilla.com>
Mon, 19 Mar 2018 06:55:21 -0700
changeset 463390 5988e21167c2913edadb20fa73d7ade380a602f7
parent 463389 e6cdf63c59a494a79197fcefca78a83399244a8e
child 463391 71cfdba55f269cc95196149303d8705b9030864d
push id1683
push usersfraser@mozilla.com
push dateThu, 26 Apr 2018 16:43:40 +0000
treeherdermozilla-release@5af6cb21869d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjesup, NPOTB
bugs1437345
milestone60.0
Bug 1437345 - Set defaults for gn visual studio build; r=jesup a=NPOTB This hard codes the visual studio version to 2015. We did the same thing for the gyp build. It also sets default paths for visual studio, which are ignored by the remainder of the build system. This was required to get gn code generation working on a fresh install of Windows. I must have had similar changes on my old Windows VM but missed commiting them as part of the gyp to gn build switch. MozReview-Commit-ID: 7fYngpdIwxh
media/webrtc/trunk/build/config/win/visual_studio_version.gni
--- a/media/webrtc/trunk/build/config/win/visual_studio_version.gni
+++ b/media/webrtc/trunk/build/config/win/visual_studio_version.gni
@@ -1,25 +1,25 @@
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 declare_args() {
   # Path to Visual Studio. If empty, the default is used which is to use the
   # automatic toolchain in depot_tools. If set, you must also set the
   # visual_studio_version and wdk_path.
-  visual_studio_path = ""
+  visual_studio_path = "."
 
   # Version of Visual Studio pointed to by the visual_studio_path.
   # Currently always "2015".
-  visual_studio_version = ""
+  visual_studio_version = "2015"
 
   # Directory of the Windows driver kit. If visual_studio_path is empty, this
   # will be auto-filled.
-  wdk_path = ""
+  wdk_path = "."
 
   # Full path to the Windows SDK, not including a backslash at the end.
   # This value is the default location, override if you have a different
   # installation location.
   windows_sdk_path = "C:\Program Files (x86)\Windows Kits\10"
 }
 
 if (visual_studio_path == "") {