Bug 1423548: Use BaseRect access methods instead of member variables in toolkit/ r=jaws
authorMilan Sreckovic <milan@mozilla.com>
Wed, 10 Jan 2018 11:18:49 -0500
changeset 453337 58ad438f1d3815f83aa04c1fce6d7527cedec1a4
parent 453336 744a3f069aecde8e9583a15601fd15d85f63360d
child 453338 fc2b357b243e42f4637cbdc029ae2ae1d0cd72c2
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs1423548
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1423548: Use BaseRect access methods instead of member variables in toolkit/ r=jaws MozReview-Commit-ID: ASnjeke9S4D
toolkit/components/browser/nsWebBrowser.cpp
--- a/toolkit/components/browser/nsWebBrowser.cpp
+++ b/toolkit/components/browser/nsWebBrowser.cpp
@@ -1423,26 +1423,26 @@ nsWebBrowser::GetPositionAndSize(int32_t
     }
     if (aCY) {
       *aCY = mInitInfo->cy;
     }
   } else if (mInternalWidget) {
     LayoutDeviceIntRect bounds = mInternalWidget->GetBounds();
 
     if (aX) {
-      *aX = bounds.x;
+      *aX = bounds.X();
     }
     if (aY) {
-      *aY = bounds.y;
+      *aY = bounds.Y();
     }
     if (aCX) {
-      *aCX = bounds.width;
+      *aCX = bounds.Width();
     }
     if (aCY) {
-      *aCY = bounds.height;
+      *aCY = bounds.Height();
     }
     return NS_OK;
   } else {
     // Can directly return this as it is the
     // same interface, thus same returns.
     return mDocShellAsWin->GetPositionAndSize(aX, aY, aCX, aCY);
   }
   return NS_OK;
@@ -1745,18 +1745,18 @@ DrawPaintedLayer(PaintedLayer* aLayer,
                  DrawRegionClip aClip,
                  const nsIntRegion& aRegionToInvalidate,
                  void* aCallbackData)
 {
   DrawTarget& aDrawTarget = *aContext->GetDrawTarget();
 
   ColorPattern color(ToDeviceColor(*static_cast<nscolor*>(aCallbackData)));
   nsIntRect dirtyRect = aRegionToDraw.GetBounds();
-  aDrawTarget.FillRect(
-    Rect(dirtyRect.x, dirtyRect.y, dirtyRect.width, dirtyRect.height), color);
+  aDrawTarget.FillRect( Rect(dirtyRect.X(), dirtyRect.Y(),
+                             dirtyRect.Width(), dirtyRect.Height()), color);
 }
 
 void
 nsWebBrowser::WindowActivated()
 {
 #if defined(DEBUG_smaug)
   nsCOMPtr<nsIDocument> document = mDocShell->GetDocument();
   nsAutoString documentURI;