Bug 1275707, part 3 - Rename MESSAGE_MANAGER_MESSAGE_SIZE. r=baku
authorAndrew McCreight <continuation@gmail.com>
Wed, 01 Jun 2016 15:11:06 -0700
changeset 341046 5885ad0c0a1d9fd25143692d3200a8ec2dcd80f0
parent 341045 ef70956cd95cf49221eb9055f783dbd7fa7bfdb6
child 341047 23080ad39e3051ab76f181e7e3cb32875e87bd17
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1275707
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1275707, part 3 - Rename MESSAGE_MANAGER_MESSAGE_SIZE. r=baku Now that digits have been filtered out of the message manager message names to avoid creating thousands of similar keys, we can reenable the telemetry by renaming it. Also, update the description to address bsmedberg's comments, and add me to the list of alert emails.
dom/base/nsFrameMessageManager.cpp
toolkit/components/telemetry/Histograms.json
--- a/dom/base/nsFrameMessageManager.cpp
+++ b/dom/base/nsFrameMessageManager.cpp
@@ -710,17 +710,17 @@ RecordMessageSize(size_t aDataLength, co
 
   if (aDataLength < kMinTelemetryMessageSize) {
     return;
   }
 
   NS_ConvertUTF16toUTF8 messageName(aMessageName);
   messageName.StripChars("0123456789");
 
-  Telemetry::Accumulate(Telemetry::MESSAGE_MANAGER_MESSAGE_SIZE, messageName,
+  Telemetry::Accumulate(Telemetry::MESSAGE_MANAGER_MESSAGE_SIZE2, messageName,
                         aDataLength);
 }
 
 nsresult
 nsFrameMessageManager::SendMessage(const nsAString& aMessageName,
                                    JS::Handle<JS::Value> aJSON,
                                    JS::Handle<JS::Value> aObjects,
                                    nsIPrincipal* aPrincipal,
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10744,25 +10744,26 @@
     "bug_numbers": [1264820],
     "expires_in_version": "55",
     "kind": "exponential",
     "high": 8000000,
     "n_buckets": 50,
     "keyed": true,
     "description": "Measures the size of IPC messages by message name"
   },
-  "MESSAGE_MANAGER_MESSAGE_SIZE": {
-    "alert_emails": ["wmccloskey@mozilla.com"],
+  "MESSAGE_MANAGER_MESSAGE_SIZE2": {
+    "alert_emails": ["wmccloskey@mozilla.com","amccreight@mozilla.com"],
     "bug_numbers": [1260908],
     "expires_in_version": "55",
     "kind": "exponential",
+    "low": 8192,
     "high": 8000000,
     "n_buckets": 50,
     "keyed": true,
-    "description": "Measures the size of message manager messages by message name"
+    "description": "Each key is the message name, with digits removed, from an async message manager message that was larger than 8192 bytes, recorded in the sending process at the time of sending."
   },
   "SANDBOX_BROKER_INITIALIZED": {
     "alert_emails": ["bowen@mozilla.com"],
     "bug_numbers": [1256992],
     "expires_in_version": "55",
     "kind": "boolean",
     "description": "Result of call to SandboxBroker::Initialize"
   },