Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. r=dholbert
authorBrad Werth <bwerth@mozilla.com>
Wed, 14 Mar 2018 14:49:57 -0700
changeset 471647 581d1a27f4eff370799aef05a2375d69f423f4b7
parent 471646 0cb6c9f7c6dbf71e5143b901de1dd3aa128f949d
child 471648 36bf72f6946dbbe896a52456af4b7fd33ba8a1c2
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1265342
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1265342 Part 8: Update shape-outside inset tests to explicitly set a line-height of 1, and not rely on a UA-specific value. r=dholbert https://www.w3.org/TR/CSS2/visudet.html#propdef-line-height specifies that line-height is given an initial value of normal, which is defined: Tells user agents to set the used value to a "reasonable" value based on the font of the element. The value has the same meaning as <number>. We recommend a used value for 'normal' between 1.0 to 1.2. The computed value is 'normal'. These tests are designed to work correctly if and only if the line-height is 1. This change specifies line-height: 1 explicitly. MozReview-Commit-ID: 3Ueassok0f
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html
testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html
@@ -14,18 +14,17 @@
     <style>
         #container {
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
-            font-family: Ahem;
-            font-size: 25px;
+            font: 25px/1 Ahem;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 200px;
             height: 200px;
             shape-outside: inset(50px 100px 50px 0px);
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html
@@ -16,16 +16,17 @@
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
             font-family: Ahem;
             font-size: 25px;
+            line-height: 1;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 200px;
             height: 200px;
             shape-outside: inset(25% 50% 25% 0%);
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html
@@ -17,16 +17,17 @@
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
             font-family: Ahem;
             font-size: 25px;
+            line-height: 1;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 50px;
             height: 50px;
             border: 25px solid red;
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html
@@ -17,16 +17,17 @@
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
             font-family: Ahem;
             font-size: 25px;
+            line-height: 1;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 50px;
             height: 50px;
             border: 25px solid red;
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html
@@ -17,16 +17,17 @@
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
             font-family: Ahem;
             font-size: 25px;
+            line-height: 1;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 50px;
             height: 50px;
             border: 25px solid red;
--- a/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html
+++ b/testing/web-platform/tests/css/css-shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html
@@ -17,16 +17,17 @@
             position: relative;
             margin-left: 25px;
         }
         #test-container {
             width: 200px;
             height: 200px;
             font-family: Ahem;
             font-size: 25px;
+            line-height: 1;
             background-color: red;
             color: green;
         }
         #test-shape {
             float: left;
             width: 50px;
             height: 50px;
             border: 25px solid red;