Bug 1496823 - Remove -[ChildView setNeedsDisplayInRect:] override. r=spohl
authorMarkus Stange <mstange@themasta.com>
Wed, 17 Oct 2018 20:47:29 +0000
changeset 500295 56dc11bab861326c3981f8a38f08027a2b90ae7a
parent 500294 8848453f27af6f3ae1538e9cbadef50bf4e95455
child 500296 d1d878123a68f2f7bcd4f31f57fd7eb648975ada
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersspohl
bugs1496823
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1496823 - Remove -[ChildView setNeedsDisplayInRect:] override. r=spohl This override was intended to ignore unnecessary nsChildView::Invalidate calls when using main thread OpenGL. With OMTC, Gecko no longer calls Invalidate in those cases, it just composites on the compositor thread, and the widget's main thread code doesn't really hear about it. So this workaround is no longer necessary. Depends on D7925 Differential Revision: https://phabricator.services.mozilla.com/D7927
widget/cocoa/nsChildView.mm
--- a/widget/cocoa/nsChildView.mm
+++ b/widget/cocoa/nsChildView.mm
@@ -3493,24 +3493,16 @@ NSEvent* gLastDragMouseDownEvent = nil;
       nsIPresShell* presShell = listener->GetPresShell();
       if (presShell) {
         presShell->ReconstructFrames();
       }
     }
   }
 }
 
-- (void)setNeedsDisplayInRect:(NSRect)aRect
-{
-  if (![self isUsingOpenGL]) {
-    [super setNeedsDisplayInRect:aRect];
-    return;
-  }
-}
-
 - (NSString*)description
 {
   NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL;
 
   return [NSString stringWithFormat:@"ChildView %p, gecko child %p, frame %@", self, mGeckoChild, NSStringFromRect([self frame])];
 
   NS_OBJC_END_TRY_ABORT_BLOCK_NIL;
 }