Bug 1414237 - Remove bogus styles from listbox.css on Linux. r=johannh
authorDão Gottwald <dao@mozilla.com>
Fri, 03 Nov 2017 12:53:17 +0100
changeset 443329 568b366e806cfaddd34f72a334b2fcea8232a982
parent 443328 d4d10e329d1b5e8009ae0465bbdd1cae29475522
child 443330 172216504d787aa6ad0448e929dcfde8c1e8047f
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjohannh
bugs1414237
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1414237 - Remove bogus styles from listbox.css on Linux. r=johannh There's a bunch of borders that aren't used because of -moz-appearance, and listheader have extra padding that shouldn't be there because -moz-appearance takes care of that. MozReview-Commit-ID: LbqKADfO3tf
toolkit/themes/linux/global/listbox.css
--- a/toolkit/themes/linux/global/listbox.css
+++ b/toolkit/themes/linux/global/listbox.css
@@ -8,35 +8,26 @@
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* ::::: listbox ::::: */
 
 listbox {
   -moz-appearance: listbox;
   margin: 2px 4px;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
-  -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
   background-color: -moz-Field;
   color: -moz-FieldText;
 }
 
 listbox[disabled="true"] {
   color: GrayText;
 }
 
 /* ::::: listitem ::::: */
 
-listitem {
-  border: 1px solid transparent;
-}
-
 listbox:focus > listitem[selected="true"][current="true"] {
   outline: 1px dotted #F3D982;
 }
 
 listbox:focus > listitem[current="true"] {
   outline: 1px dotted Highlight;
   outline-offset: -1px;
 }
@@ -51,83 +42,54 @@ listbox:focus > listitem[selected="true"
   color: HighlightText;
 }
 
 /* ::::: listheader ::::: */
 
 listheader { 
   -moz-appearance: treeheadercell;
   -moz-box-align: center;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
   background-color: -moz-Dialog;
   color: -moz-DialogText;
-  padding: 0 2px;
-}
-
-listheader:hover {
-  color: -moz-buttonhovertext;
-}
-
-listheader[sortable="true"]:hover:active {
-  color: ButtonText;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
-  -moz-border-right-colors: ThreeDShadow transparent;
-  -moz-border-bottom-colors: ThreeDShadow transparent;
-  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
-  padding-top: 0px;
-  padding-bottom: 0px;
-  padding-inline-start: 3px;
-  padding-inline-end: 1px;
 }
 
 .listheader-icon {
   margin-inline-end: 2px;
 }
 
-.listheader-icon[sortable="true"]:hover:active {
-  margin-inline-end: 1px;
-}
-
 .listheader-label {
-  margin: 0px !important;
+  margin: 0 !important;
 }
 
 /* ..... sort direction icon ..... */
 
 .listheader-sortdirection {
   -moz-appearance: treeheadersortarrow;
 }
 
 /* ::::: listcell ::::: */
 
 .listcell-label {
-  margin: 0px !important;
-  padding-top: 0px;
+  margin: 0 !important;
+  padding-top: 0;
   padding-bottom: 1px;
   padding-inline-start: 4px;
-  padding-inline-end: 0px;
+  padding-inline-end: 0;
   white-space: nowrap;
 }
 
 .listcell-icon {
   margin-inline-end: 2px;
 }
 
 .listcell-label[disabled="true"] {
   color: GrayText;
 }
 
 /* ::::: listcell checkbox ::::: */
 
 .listcell-check {
   -moz-appearance: checkbox;
   -moz-box-align: center;
-  margin: 0px 2px;
-  border: 1px solid -moz-DialogText;
+  margin: 0 2px;
   min-width: 13px;
   min-height: 13px;
-  background: -moz-Field no-repeat 50% 50%;
 }