Bug 1429056 - Don't strip llvm-dsymutil. r=ted
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 19 Jan 2018 10:16:11 +0900
changeset 454334 558cb0501f8e6c2362c408342ca278cd5057e942
parent 454333 973377f16727ad3967dfaf61d06614659df3118f
child 454335 afec89310b68fd483e221d122f6f97d8778282b0
push id1648
push usermtabara@mozilla.com
push dateThu, 01 Mar 2018 12:45:47 +0000
treeherdermozilla-release@cbb9688c2eeb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1429056, 1430315
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429056 - Don't strip llvm-dsymutil. r=ted When I originally wrote the llvm-dsymutil build script in bug 1430315, I wasn't setting CMAKE_BUILD_TYPE to Release, and was ending up with a very large binary (> 300MB), so I stripped it. When I later set CMAKE_BUILD_TYPE to Release, I left the manual stripping on, but that removes symbols that are useful for stacktraces when dsymutil crashes (the Release type still leaves out debug info).
taskcluster/scripts/misc/build-llvm-dsymutil.sh
--- a/taskcluster/scripts/misc/build-llvm-dsymutil.sh
+++ b/taskcluster/scripts/misc/build-llvm-dsymutil.sh
@@ -25,14 +25,12 @@ cmake \
   -DLLVM_TARGETS_TO_BUILD=X86 \
   -DCMAKE_C_COMPILER=$HOME_DIR/src/gcc/bin/gcc \
   ..
 
 export LD_LIBRARY_PATH=$HOME_DIR/src/gcc/lib64
 
 ninja llvm-dsymutil
 
-strip bin/llvm-dsymutil
-
 tar --xform='s,^,llvm-dsymutil/,' -Jcf llvm-dsymutil.tar.xz bin/llvm-dsymutil
 
 mkdir -p $UPLOAD_DIR
 cp llvm-dsymutil.tar.xz $UPLOAD_DIR