Bug 684397 - Form autocomplete arrowbox has no arrow in Honeycomb theme [r=sriram]
authorMatt Brubeck <mbrubeck@mozilla.com>
Wed, 07 Sep 2011 14:28:12 -0700
changeset 78002 54f6877c35a742815801efb09dc377ca974ffa97
parent 78001 d333f4021aaf7d4096e5d5757ddf8a89ad8ef072
child 78003 4f3856dd4dd0caff39d8adbdf7981c312ecf7cb4
push id78
push userclegnitto@mozilla.com
push dateFri, 16 Dec 2011 17:32:24 +0000
treeherdermozilla-release@79d24e644fdd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssriram
bugs684397
milestone9.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 684397 - Form autocomplete arrowbox has no arrow in Honeycomb theme [r=sriram]
mobile/chrome/content/bindings/arrowbox.xml
mobile/chrome/content/browser.xul
mobile/themes/core/honeycomb/platform.css
--- a/mobile/chrome/content/bindings/arrowbox.xml
+++ b/mobile/chrome/content/bindings/arrowbox.xml
@@ -40,17 +40,17 @@
     xmlns="http://www.mozilla.org/xbl"
     xmlns:xbl="http://www.mozilla.org/xbl"
     xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
 
   <binding id="arrowbox" extends="xul:box">
     <content orient="vertical">
       <xul:box anonid="container" class="panel-arrowcontainer" flex="1">
         <xul:box anonid="arrowbox" class="panel-arrowbox" dir="ltr">
-          <xul:image anonid="arrow" class="panel-arrow"/>
+          <xul:image anonid="arrow" class="panel-arrow" xbl:inherits="type"/>
         </xul:box>
         <xul:scrollbox anonid="arrowcontent" class="panel-arrowcontent" flex="1">
           <xul:box class="panel-inner-arrowcontent" xbl:inherits="align,dir,orient,pack,flex">
             <children/>
           </xul:box>
         </xul:scrollbox>
       </xul:box>
     </content>
--- a/mobile/chrome/content/browser.xul
+++ b/mobile/chrome/content/browser.xul
@@ -311,17 +311,17 @@
     </scrollbox>
 
     <!-- Form Helper suggestions helper popup -->
     <arrowbox id="form-helper-suggestions-container" flex="1" hidden="true" offset="0" top="0" left="0">
       <arrowscrollbox id="form-helper-suggestions" align="center" flex="1" orient="horizontal" onclick="FormHelperUI.doAutoComplete(event.target);"/>
     </arrowbox>
 
     <!-- popup for site identity information -->
-    <arrowbox id="identity-container" hidden="true" mode="unknownIdentity" offset="18" flex="1">
+    <arrowbox id="identity-container" hidden="true" mode="unknownIdentity" offset="18" flex="1" type="dialog">
       <hbox id="identity-popup-container" flex="1" align="top">
         <image id="identity-popup-icon"/>
         <vbox id="identity-popup-content-box" flex="1">
           <hbox flex="1">
             <label id="identity-popup-connectedToLabel" value="&identity.connectedTo2;"/>
             <label id="identity-popup-connectedToLabel2" flex="1">&identity.unverifiedsite2;</label>
             <description id="identity-popup-content-host" flex="1"/>
           </hbox>
@@ -354,17 +354,17 @@
         <pageaction id="pageaction-reset" title="&pageactions.reset;"
           onclick="PageActions.clearPagePermissions(event);"/>
         <pageaction id="pageaction-search" title="&pageactions.search.addNew;"/>
         <pageaction id="pageaction-charset" title="&pageactions.charEncoding;" onclick="CharsetMenu.show();"/>
         <pageaction id="pageaction-webapps-install" title="&pageactions.webapps.install;" onclick="WebappsUI.show();"/>
       </hbox>
     </arrowbox>
 
-    <arrowbox id="bookmark-popup" hidden="true" align="stretch" offset="12">
+    <arrowbox id="bookmark-popup" hidden="true" align="stretch" offset="12" type="dialog">
       <hbox id="bookmark-popup-title">
         <label value="&bookmarkPopup.label;"/>
       </hbox>
       <richlistbox id="bookmark-popup-commands" class="action-buttons" onclick="BookmarkPopup.hide();" flex="1">
         <richlistitem class="action-button" id="bookmark-popup-edit" onclick="BookmarkHelper.edit();">
           <label value="&bookmarkEdit.label;"/>
         </richlistitem>
         <richlistitem class="action-button" id="bookmark-popup-remove" onclick="BookmarkPopup.hide(); BookmarkHelper.removeBookmarksForURI(getBrowser().currentURI);">
@@ -386,17 +386,17 @@
         <separator id="bookmark-form-line" class="prompt-line"/>
         <scrollbox id="bookmark-form" align="start" class="prompt-message" flex="1"/>
         <hbox id="bookmark-form-buttons" pack="center" class="prompt-buttons">
           <button label="&editBookmarkDone.label;" class="prompt-button" oncommand="BookmarkHelper.save();"/>
         </hbox>
       </dialog>
     </box>
 
-    <arrowbox id="appmenu-popup" hidden="true">
+    <arrowbox id="appmenu-popup" hidden="true" type="dialog">
       <box id="appmenu-popup-sitecommands"/>
       <richlistbox id="appmenu-popup-appcommands"/>
     </arrowbox>
 
     <box id="panel-container" hidden="true" class="window-width window-height panel-dark"
          style="-moz-stack-sizing: ignore" left="10000">
       <box id="panel-container-inner" flex="1" class="panel-dark">
         <box id="panel-controls" class="panel-row-header" oncommand="BrowserUI.switchPane(event.target.getAttribute('linkedpanel'));">
--- a/mobile/themes/core/honeycomb/platform.css
+++ b/mobile/themes/core/honeycomb/platform.css
@@ -627,16 +627,37 @@ dialog {
 }
 
 .prompt-edit {
   margin: @margin_xnormal@;
   font-size: @font_normal@;
   text-align: start;
 }
 
+.panel-arrow[side="top"]:not([type="dialog"]) {
+  list-style-image: url("chrome://browser/skin/images/arrowbox-up.png");
+  margin-bottom: -@margin_normal@;
+}
+
+.panel-arrow[side="bottom"]:not([type="dialog"]) {
+  list-style-image: url("chrome://browser/skin/images/arrowbox-down.png");
+  margin-top: -@margin_normal@;
+}
+
+.panel-arrow[side="left"]:not([type="dialog"]) {
+  list-style-image: url("chrome://browser/skin/images/arrowbox-horiz.png");
+  margin-right: -@margin_normal@;
+  -moz-transform: scaleX(-1);
+}
+
+.panel-arrow[side="right"]:not([type="dialog"]) {
+  list-style-image: url("chrome://browser/skin/images/arrowbox-horiz.png");
+  margin-left: -@margin_normal@;
+}
+
 /*.panel-row-header ------------------------------------------------------------ */
 .panel-row-header {
   background-color: @color_background_panelrow@ !important;
   color: @color_text_panelrow@;
   padding: 0 !important;
 }
 
 .panel-row-button {