Bug 1458363 - Remove WEAVE_ENGINE_SYNC_ERRORS histogram. r=chutten,kitcambridge
authorMark Hammond <mhammond@skippinet.com.au>
Wed, 02 May 2018 12:42:07 +1000
changeset 472967 54bd7eb9c5efe65284eba06765b0e2c18f870224
parent 472966 4ceda3f51c7727acf2a23eb6047e4734f2b111e5
child 472968 d42fb2ba68a48881c1ea0e1540767a515792379b
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschutten, kitcambridge
bugs1458363
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1458363 - Remove WEAVE_ENGINE_SYNC_ERRORS histogram. r=chutten,kitcambridge MozReview-Commit-ID: 6upLHPBWhzz
services/sync/modules/policies.js
services/sync/tests/unit/test_errorhandler_2.js
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/services/sync/modules/policies.js
+++ b/services/sync/modules/policies.js
@@ -721,18 +721,16 @@ ErrorHandler.prototype = {
 
         this.checkServerError(exception);
 
         Status.engines = [engine_name, exception.failureCode || ENGINE_UNKNOWN_FAIL];
         if (Async.isShutdownException(exception)) {
           this._log.debug(engine_name + " was interrupted due to the application shutting down");
         } else {
           this._log.debug(engine_name + " failed", exception);
-          Services.telemetry.getKeyedHistogramById("WEAVE_ENGINE_SYNC_ERRORS")
-                            .add(engine_name);
         }
         break;
       }
       case "weave:service:login:error":
         this._log.error("Sync encountered a login error");
         this.resetFileLog();
         break;
       case "weave:service:sync:error": {
--- a/services/sync/tests/unit/test_errorhandler_2.js
+++ b/services/sync/tests/unit/test_errorhandler_2.js
@@ -403,20 +403,16 @@ add_task(async function test_sync_engine
 
   // Test Error log was written on SYNC_FAILED_PARTIAL.
   let logFiles = getLogFiles();
   equal(logFiles.length, 1);
   Assert.ok(logFiles[0].leafName.startsWith("error-sync-"), logFiles[0].leafName);
 
   await clean();
 
-  let syncErrors = sumHistogram("WEAVE_ENGINE_SYNC_ERRORS", { key: "catapult" });
-  Assert.ok(syncErrors, 1);
-
-  await clean();
   await promiseStopServer(server);
 });
 
 add_task(async function test_logs_on_sync_error() {
   enableValidationPrefs();
 
   _("Ensure that an error is still logged when weave:service:sync:error " +
     "is notified, despite shouldReportError returning false.");
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -12123,26 +12123,16 @@
     "alert_emails": ["sync-dev@mozilla.org"],
     "bug_numbers": [1232050],
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 10,
     "releaseChannelCollection": "opt-out",
     "description": "Number of mobile devices associated with this Sync account. Recorded each time Sync successfully completes the 'clients' engine."
   },
-  "WEAVE_ENGINE_SYNC_ERRORS": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["sync-dev@mozilla.org"],
-    "bug_numbers": [1236383],
-    "expires_in_version": "never",
-    "kind": "count",
-    "keyed": true,
-    "releaseChannelCollection": "opt-out",
-    "description": "Exceptions thrown by a Sync engine. Keyed on the engine name."
-  },
   "CONTENT_DOCUMENTS_DESTROYED": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "count",
     "description": "Number of content documents destroyed; used in conjunction with use counter histograms"
   },
   "TOP_LEVEL_CONTENT_DOCUMENTS_DESTROYED": {
     "record_in_processes": ["main", "content"],
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -1685,17 +1685,16 @@
     "UPDATE_NOT_PREF_UPDATE_STAGING_ENABLED_NOTIFY",
     "UPDATE_PING_COUNT_EXTERNAL",
     "UPDATE_PING_COUNT_NOTIFY",
     "UPDATE_SERVICE_MANUALLY_UNINSTALLED_EXTERNAL",
     "UPDATE_SERVICE_MANUALLY_UNINSTALLED_NOTIFY",
     "UPDATE_UNABLE_TO_APPLY_EXTERNAL",
     "UPDATE_UNABLE_TO_APPLY_NOTIFY",
     "VIDEO_FASTSEEK_USED",
-    "WEAVE_ENGINE_SYNC_ERRORS",
     "WEBFONT_PER_PAGE",
     "WEBRTC_CALL_COUNT_2",
     "WEBVTT_USED_VTT_CUES",
     "WEB_NOTIFICATION_CLICKED",
     "WEB_NOTIFICATION_EXCEPTIONS_OPENED",
     "WEB_NOTIFICATION_SHOWN",
     "XUL_CACHE_DISABLED"
   ]