Bug 1500240 - Use getAnonymousElementByAttribute instead of getElementByID for XBL anonymous search element;r=dao
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 19 Oct 2018 09:17:06 +0000
changeset 500611 53abc33e3e38ea49862e20af8974bb5f8a17f439
parent 500610 0927741e9110eebe9d55a73f97fd8bb47f2d6bff
child 500612 14e469a4365b820bfb1a890c6993edb118a60d4f
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1500240
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1500240 - Use getAnonymousElementByAttribute instead of getElementByID for XBL anonymous search element;r=dao Differential Revision: https://phabricator.services.mozilla.com/D9150
browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
--- a/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
+++ b/browser/base/content/test/urlbar/browser_urlbarSearchSuggestions_opt-out.js
@@ -50,17 +50,17 @@ add_task(async function focus() {
   // Start searching.
   EventUtils.sendString("rnd");
   await promiseSearchComplete();
   Assert.ok(suggestionsPresent());
   assertVisible(true);
   assertFooterVisible(true);
 
   // Check the Change Options link.
-  let changeOptionsLink = document.getElementById("search-suggestions-change-settings");
+  let changeOptionsLink = document.getAnonymousElementByAttribute(gURLBar.popup, "id", "search-suggestions-change-settings");
   let prefsPromise = BrowserTestUtils.waitForLocationChange(gBrowser, "about:preferences#search");
   changeOptionsLink.click();
   await prefsPromise;
   Assert.ok(!gURLBar.popup.popupOpen, "popup should be closed");
   // The preferences page does fancy stuff with focus, ensure to unload it.
   await BrowserTestUtils.loadURI(gBrowser.selectedBrowser, "about:blank");
 });