Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels r=bobowen
authorAlex Gaynor <agaynor@mozilla.com>
Fri, 09 Jun 2017 11:24:07 -0400
changeset 413710 5378ea8f1894428451efbac3e5e225b34a348ff1
parent 413709 68f271f79ce6630fc2c75c0d8f291a20e004b83e
child 413711 2d90236d15722d3aeeaf721d1050fa74b21adb92
push id1490
push usermtabara@mozilla.com
push dateMon, 31 Jul 2017 14:08:16 +0000
treeherdermozilla-release@70e32e6bf15e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbobowen
bugs1371701
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1371701 - Fixed sandboxing tests to reflect that we're enabling file content process for all channels r=bobowen MozReview-Commit-ID: ICXZjEU2n6L
security/sandbox/test/browser_content_sandbox_fs.js
--- a/security/sandbox/test/browser_content_sandbox_fs.js
+++ b/security/sandbox/test/browser_content_sandbox_fs.js
@@ -218,30 +218,20 @@ function* createTempFile() {
   ok(fileDeleted == true, "deleting a file in content temp is permitted");
 }
 
 // Test reading files and dirs from web and file content processes.
 function* testFileAccess() {
   // for tests that run in a web content process
   let webBrowser = gBrowser.selectedBrowser;
 
-  // For now, we'll only test file access from the file content process if
-  // the file content process is enabled. Once the file content process is
-  // ready to ride the trains, this test should be changed to always test
-  // file content process access. We use todo() to cause failures
-  // if the file process is enabled on a non-Nightly release so that we'll
-  // know to update this test to always run the tests. i.e., we'll want to
-  // catch bugs that accidentally disable file content process.
+  // Ensure that the file content process is enabled.
   let fileContentProcessEnabled =
     prefs.getBoolPref("browser.tabs.remote.separateFileUriProcess");
-  if (isNightly()) {
-    ok(fileContentProcessEnabled, "separate file content process is enabled");
-  } else {
-    todo(fileContentProcessEnabled, "separate file content process is enabled");
-  }
+  ok(fileContentProcessEnabled, "separate file content process is enabled");
 
   // for tests that run in a file content process
   let fileBrowser = undefined;
   if (fileContentProcessEnabled) {
     // open a tab in a file content process
     gBrowser.selectedTab =
       BrowserTestUtils.addTab(gBrowser, "about:blank", {preferredRemoteType: "file"});
     // get the browser for the file content process tab