Bug 1447235 - Enable the console sidebar in Nightly; r=bgrins.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Fri, 27 Apr 2018 16:29:55 +0200
changeset 472743 4dbde138d6305db19fc4b35800fbdaba2fa9d2cf
parent 472742 b860b811cbb04a993b1c12af0fe72477c79c9978
child 472744 a662fe1cc8bad97245bf194c8707c088a0169304
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1447235, 1419292
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1447235 - Enable the console sidebar in Nightly; r=bgrins. In Bug 1419292, we make sure there is no issue when releasing actors for the output messages, so the sidebar is probably good to go on Nighly in order to get more feedback. The test for context menu entries in the console was updated since it now shows the "Open in sidebar" entry. MozReview-Commit-ID: 8R3rhf944Fh
devtools/client/preferences/devtools-client.js
devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js
--- a/devtools/client/preferences/devtools-client.js
+++ b/devtools/client/preferences/devtools-client.js
@@ -283,18 +283,22 @@ pref("devtools.netmonitor.persistlog", f
 // in the Web Console to display a timestamp, or |false| to not display
 // any timestamps.
 pref("devtools.webconsole.timestampMessages", false);
 
 // Web Console automatic multiline mode: |true| if you want incomplete statements
 // to automatically trigger multiline editing (equivalent to shift + enter).
 pref("devtools.webconsole.autoMultiline", true);
 
-// Enable the webconsole sidebar toggle
+// Enable the webconsole sidebar toggle in Nightly builds.
+#if defined(NIGHTLY_BUILD)
+pref("devtools.webconsole.sidebarToggle", true);
+#else
 pref("devtools.webconsole.sidebarToggle", false);
+#endif
 
 // Disable the new performance recording panel by default
 pref("devtools.performance.new-panel-enabled", false);
 
 // Enable client-side mapping service for source maps
 pref("devtools.source-map.client-service.enabled", true);
 
 // The number of lines that are displayed in the web console.
--- a/devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js
+++ b/devtools/client/webconsole/test/mochitest/browser_console_context_menu_entries.js
@@ -27,17 +27,18 @@ add_task(async function() {
   ok(menuPopup, "The context menu is displayed on a network message");
 
   let expectedContextMenu = [
     "#console-menu-copy-url (a)",
     "#console-menu-open-url (T)",
     "#console-menu-store (S) [disabled]",
     "#console-menu-copy (C)",
     "#console-menu-copy-object (o) [disabled]",
-    "#console-menu-select (A)"
+    "#console-menu-select (A)",
+    "#console-menu-open-sidebar (V) [disabled]",
   ];
   is(getSimplifiedContextMenu(menuPopup).join("\n"), expectedContextMenu.join("\n"),
     "The context menu has the expected entries for a network message");
 
   info("Logging a text message in the content window");
   const onLogMessage = waitForMessage(hud, "simple text message");
   ContentTask.spawn(gBrowser.selectedBrowser, null, () => {
     content.wrappedJSObject.console.log("simple text message");
@@ -46,17 +47,18 @@ add_task(async function() {
   const logMessage = await onLogMessage;
   menuPopup = await openContextMenu(hud, logMessage.node);
   ok(menuPopup, "The context menu is displayed on a log message");
 
   expectedContextMenu = [
     "#console-menu-store (S) [disabled]",
     "#console-menu-copy (C)",
     "#console-menu-copy-object (o) [disabled]",
-    "#console-menu-select (A)"
+    "#console-menu-select (A)",
+    "#console-menu-open-sidebar (V) [disabled]",
   ];
   is(getSimplifiedContextMenu(menuPopup).join("\n"), expectedContextMenu.join("\n"),
     "The context menu has the expected entries for a simple log message");
 
   await hideContextMenu(hud);
 });
 
 function getSimplifiedContextMenu(popupElement) {