Bug 1033833 - Remove signaling unittests for createAnswer options. r=abr
authorJan-Ivar Bruaroey <jib@mozilla.com>
Fri, 18 Jul 2014 17:58:55 -0400
changeset 217164 4c72ab9bc7016f4e6b3d5035c4cca22117d0e9d5
parent 217163 870f07d03e2a857dac2df44aad6e9f41203cd6ab
child 217165 2fd3b40213101d11eb3d0ef89346e0711b9b17bd
push id515
push userraliiev@mozilla.com
push dateMon, 06 Oct 2014 12:51:51 +0000
treeherdermozilla-release@267c7a481bef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersabr
bugs1033833
milestone33.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1033833 - Remove signaling unittests for createAnswer options. r=abr
media/webrtc/signaling/test/signaling_unittests.cpp
--- a/media/webrtc/signaling/test/signaling_unittests.cpp
+++ b/media/webrtc/signaling/test/signaling_unittests.cpp
@@ -2048,155 +2048,175 @@ TEST_F(SignalingTest, DISABLED_CreateOff
 
 TEST_F(SignalingTest, OfferAnswerNothingDisabled)
 {
   sipcc::OfferOptions options;
   OfferAnswer(options, OFFER_AV | ANSWER_AV, false,
               SHOULD_SENDRECV_AV, SHOULD_SENDRECV_AV);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontReceiveAudioOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontReceiveAudioOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", false);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_AV,
               false, SHOULD_SEND_AUDIO | SHOULD_SENDRECV_VIDEO,
               SHOULD_RECV_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontReceiveVideoOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontReceiveVideoOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", false);
   OfferAnswer(options, OFFER_AV | ANSWER_AV,
               false, SHOULD_SENDRECV_AUDIO | SHOULD_SEND_VIDEO,
               SHOULD_SENDRECV_AUDIO | SHOULD_RECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontReceiveAudioOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontReceiveAudioOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_AV,
               false, SHOULD_SENDRECV_AV,
               SHOULD_SEND_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontReceiveVideoOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontReceiveVideoOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_AV,
               false, SHOULD_SENDRECV_AV,
               SHOULD_SENDRECV_AUDIO | SHOULD_SEND_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddAudioStreamOnOfferRecvAudio)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddAudioStreamOnOfferRecvAudio)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_VIDEO | ANSWER_AV,
               false, SHOULD_RECV_AUDIO | SHOULD_SENDRECV_VIDEO,
               SHOULD_SEND_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddAudioStreamOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddAudioStreamOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", false);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_VIDEO | ANSWER_AV,
               false, SHOULD_OMIT_AUDIO | SHOULD_SENDRECV_VIDEO,
               SHOULD_OMIT_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddVideoStreamOnOfferRecvVideo)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddVideoStreamOnOfferRecvVideo)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AUDIO | ANSWER_AV,
               false, SHOULD_SENDRECV_AUDIO | SHOULD_RECV_VIDEO,
               SHOULD_SENDRECV_AUDIO | SHOULD_SEND_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddVideoStreamOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddVideoStreamOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", false);
   OfferAnswer(options, OFFER_AUDIO | ANSWER_AV,
               false, SHOULD_SENDRECV_AUDIO | SHOULD_OMIT_VIDEO,
               SHOULD_SENDRECV_AUDIO | SHOULD_OMIT_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddAudioStreamOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddAudioStreamOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_VIDEO,
               false, SHOULD_SENDRECV_AV,
               SHOULD_RECV_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddVideoStreamOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest, DISABLED_OfferAnswerDontAddVideoStreamOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_AUDIO,
               false, SHOULD_SENDRECV_AV,
               SHOULD_SENDRECV_AUDIO | SHOULD_RECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddVideoStreamOnAnswerDontReceiveVideoOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest,
+       DISABLED_OfferAnswerDontAddVideoStreamOnAnswerDontReceiveVideoOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_AUDIO,
               false, SHOULD_SENDRECV_AV, SHOULD_SENDRECV_AUDIO );
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddAudioStreamOnAnswerDontReceiveAudioOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest,
+       DISABLED_OfferAnswerDontAddAudioStreamOnAnswerDontReceiveAudioOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_AV | ANSWER_VIDEO,
               false, SHOULD_SENDRECV_AV,
               SHOULD_REJECT_AUDIO | SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddAudioStreamOnOfferDontReceiveAudioOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest,
+       DISABLED_OfferAnswerDontAddAudioStreamOnOfferDontReceiveAudioOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", false);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_VIDEO | ANSWER_AV,
               false, SHOULD_SENDRECV_VIDEO, SHOULD_SENDRECV_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontAddVideoStreamOnOfferDontReceiveVideoOnOffer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest,
+       DISABLED_OfferAnswerDontAddVideoStreamOnOfferDontReceiveVideoOnOffer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", true);
   options.setBooleanOption("OfferToReceiveVideo", false);
   OfferAnswer(options, OFFER_AUDIO | ANSWER_AV,
               false, SHOULD_SENDRECV_AUDIO | SHOULD_OMIT_VIDEO,
               SHOULD_SENDRECV_AUDIO | SHOULD_OMIT_VIDEO);
 }
 
-TEST_F(SignalingTest, OfferAnswerDontReceiveAudioNoAudioStreamOnOfferDontReceiveVideoOnAnswer)
+// XXX reject streams has changed. Re-enable when we can stop() received stream
+TEST_F(SignalingTest,
+  DISABLED_OfferAnswerDontReceiveAudioNoAudioStreamOnOfferDontReceiveVideoOnAnswer)
 {
   sipcc::OfferOptions options;
   options.setBooleanOption("OfferToReceiveAudio", false);
   options.setBooleanOption("OfferToReceiveVideo", true);
   OfferAnswer(options, OFFER_VIDEO | ANSWER_AV,
               false, SHOULD_SENDRECV_VIDEO, SHOULD_SEND_VIDEO);
 }