Bug 1415637 - Possibly incorrect MOZ_MAKE_MEM_UNDEFINED in nsTHashtable copy constructor. r=froydnj.
authorJulian Seward <jseward@acm.org>
Fri, 10 Nov 2017 11:23:12 +0100
changeset 444447 4c69cfd075773fed2ca723b5bc6f51d03c5617a5
parent 444446 21706763773360d046173f8a5321356e29eac877
child 444448 d5c94765d2ec7c8e593c8f6e8faec5a4b738cdbe
push id1618
push userCallek@gmail.com
push dateThu, 11 Jan 2018 17:45:48 +0000
treeherdermozilla-release@882ca853e05a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1415637
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1415637 - Possibly incorrect MOZ_MAKE_MEM_UNDEFINED in nsTHashtable copy constructor. r=froydnj.
xpcom/ds/nsTHashtable.h
--- a/xpcom/ds/nsTHashtable.h
+++ b/xpcom/ds/nsTHashtable.h
@@ -7,17 +7,16 @@
 #ifndef nsTHashtable_h__
 #define nsTHashtable_h__
 
 #include "PLDHashTable.h"
 #include "nsPointerHashKeys.h"
 #include "mozilla/Assertions.h"
 #include "mozilla/Attributes.h"
 #include "mozilla/fallible.h"
-#include "mozilla/MemoryChecking.h"
 #include "mozilla/MemoryReporting.h"
 #include "mozilla/Move.h"
 #include "mozilla/OperatorNewExtensions.h"
 #include "mozilla/PodOperations.h"
 #include "mozilla/TypeTraits.h"
 
 #include <new>
 
@@ -375,19 +374,16 @@ private:
 //
 // template definitions
 //
 
 template<class EntryType>
 nsTHashtable<EntryType>::nsTHashtable(nsTHashtable<EntryType>&& aOther)
   : mTable(mozilla::Move(aOther.mTable))
 {
-  // aOther shouldn't touch mTable after this, because we've stolen the table's
-  // pointers but not overwitten them.
-  MOZ_MAKE_MEM_UNDEFINED(&aOther.mTable, sizeof(aOther.mTable));
 }
 
 template<class EntryType>
 nsTHashtable<EntryType>::~nsTHashtable()
 {
 }
 
 template<class EntryType>