Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 08 Sep 2015 16:57:38 -0700
changeset 295916 4c29498bbb5caac795eec2cfae6181fba0902739
parent 295915 b9fb82ab0a0d0b16fb526b85d0298861aab4d35c
child 295917 b8f7944f92373e26b778453702e57478905f30fe
child 295981 855acc09e46c54fba1c912c27802790598993b64
push id962
push userjlund@mozilla.com
push dateFri, 04 Dec 2015 23:28:54 +0000
treeherdermozilla-release@23a2d286e80f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1202870
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1202870 - Set toolbar menu row height to 48dp. r=mhaigh I tried to use the `?android:attr/...` method listed in the nearby comments but kept receiving a "ResourceNotFound" exception. I wonder if this is related to the way we inherit and then override the themes.
mobile/android/base/resources/values-v11/dimens.xml
--- a/mobile/android/base/resources/values-v11/dimens.xml
+++ b/mobile/android/base/resources/values-v11/dimens.xml
@@ -3,11 +3,11 @@
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <resources>
 
     <!-- This is chosen to be close to Android's listPreferredItemHeightSmall.
          TODO: We should inherit these from the system.
          http://androidxref.com/4.2.2_r1/xref/frameworks/base/core/res/res/values/themes.xml#1287 -->
-    <dimen name="menu_item_row_height">44dp</dimen>
+    <dimen name="menu_item_row_height">48dp</dimen>
 
 </resources>