b=678561 fix strcmp logic error introduced in 032297452afd r=jfkthame
authorKarl Tomlinson <karlt+@karlt.net>
Fri, 26 Aug 2011 10:57:51 +1200
changeset 77480 4c05b2f72ff17b225f8dcc6badc71b31e01b7a2a
parent 77326 ca5a3569462d7b03ba1da27ed161e1d506190912
child 77481 2f4ba564a7583a934fa9129ccd2bd6e62f784ac3
push id78
push userclegnitto@mozilla.com
push dateFri, 16 Dec 2011 17:32:24 +0000
treeherdermozilla-release@79d24e644fdd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjfkthame
bugs678561
milestone9.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
b=678561 fix strcmp logic error introduced in 032297452afd r=jfkthame
gfx/thebes/gfxFontconfigUtils.cpp
--- a/gfx/thebes/gfxFontconfigUtils.cpp
+++ b/gfx/thebes/gfxFontconfigUtils.cpp
@@ -259,18 +259,18 @@ gfxFontconfigUtils::NewPattern(const nsT
             // aliases (so that the preferred font depends on language).
             // However, this would give them lower priority than subsequent
             // non-generic families in the list.  To ensure that subsequent
             // families do not have a higher priority, they are given weak
             // bindings.
             for (PRUint32 g = 0;
                  g < NS_ARRAY_LENGTH(sFontconfigGenerics);
                  ++g) {
-                if (FcStrCmpIgnoreCase(ToFcChar8(sFontconfigGenerics[g]),
-                                       ToFcChar8(family.get()))) {
+                if (0 == FcStrCmpIgnoreCase(ToFcChar8(sFontconfigGenerics[g]),
+                                            ToFcChar8(family.get()))) {
                     useWeakBinding = PR_TRUE;
                     break;
                 }
             }
         } else {
             AddWeakString(pattern, FC_FAMILY, family.get());
         }
     }