Bug 1453792 [wpt PR 10454] - Make PointerEvent fromElement/toElement return null., a=testonly
authorMustaq Ahmed <mustaq@google.com>
Sun, 22 Apr 2018 15:09:57 +0000
changeset 471427 4bbea84414ab0ea6b8abfc02c682c9e6c02e647e
parent 471426 2e40cf6fa01c585aedfb5e71c9a0233126f8a159
child 471428 bd099c6fb9cf627af469bbdfd74ff77da43a5bbc
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1453792, 10454, 827271, 986877, 550683
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1453792 [wpt PR 10454] - Make PointerEvent fromElement/toElement return null., a=testonly Automatic update from web-platform-testsMake PointerEvent fromElement/toElement return null. Also added web-platform-tests. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/G2s1Ol3qcgA Closes https://github.com/w3c/pointerevents/issues/167 Bug: 827271 Change-Id: I8429b9541f8cfc38223b3a34116b74c2aba92ee5 Reviewed-on: https://chromium-review.googlesource.com/986877 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#550683} -- wpt-commits: 81bcc8db4c676828d4b33ccb90c94049ffd831cf wpt-pr: 10454
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/pointerevents/pointerevent_support.js
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -587596,17 +587596,17 @@
    "7b2db8cf30a51490b452a5341dd5e067d0d59bf0",
    "manual"
   ],
   "pointerevents/pointerevent_styles.css": [
    "ce90dd7b3d8b71259c0581c8006fa7b93bc2e925",
    "support"
   ],
   "pointerevents/pointerevent_support.js": [
-   "a804ecbe4c7d1723b2a7eaee11e3c869cd5f56a7",
+   "26b82a24b87a7995f697d080edc2869f163c0d80",
    "support"
   ],
   "pointerevents/pointerevent_suppress_compat_events_on_click-manual.html": [
    "b092020fd1c385777ed8d8dd9ce1c27c75df5d9d",
    "manual"
   ],
   "pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-manual.html": [
    "074ac2e1e75c974a49f4615924986c7695656094",
--- a/testing/web-platform/tests/pointerevents/pointerevent_support.js
+++ b/testing/web-platform/tests/pointerevents/pointerevent_support.js
@@ -34,28 +34,31 @@ function check_PointerEvent(event, testN
     // * attribute exists
     // * has proper type
     // * if the attribute is "readonly", it cannot be changed
     // TA: 1.1, 1.2
     var idl_type_check = {
         "long": function (v) { return typeof v === "number" && Math.round(v) === v; },
         "float": function (v) { return typeof v === "number"; },
         "string": function (v) { return typeof v === "string"; },
-        "boolean": function (v) { return typeof v === "boolean" }
+        "boolean": function (v) { return typeof v === "boolean" },
+        "object": function (v) { return typeof v === "object" }
     };
     [
         ["readonly", "long", "pointerId"],
         ["readonly", "float", "width"],
         ["readonly", "float", "height"],
         ["readonly", "float", "pressure"],
         ["readonly", "long", "tiltX"],
         ["readonly", "long", "tiltY"],
         ["readonly", "string", "pointerType"],
         ["readonly", "boolean", "isPrimary"],
-        ["readonly", "long", "detail", 0]
+        ["readonly", "long", "detail", 0],
+        ["readonly", "object", "fromElement", null],
+        ["readonly", "object", "toElement", null]
     ].forEach(function (attr) {
         var readonly = attr[0];
         var type = attr[1];
         var name = attr[2];
         var value = attr[3];
 
         // existence check
         test(function () {
@@ -70,17 +73,17 @@ function check_PointerEvent(event, testN
         }
 
         // type check
         test(function () {
             assert_true(idl_type_check[type](event[name]), name + " attribute of type " + type);
         }, pointerTestName + "." + name + " IDL type " + type + " (JS type was " + typeof event[name] + ")");
 
         // value check if defined
-        if (value != undefined) {
+        if (value !== undefined) {
             test(function () {
                 assert_equals(event[name], value, name + " attribute value");
             }, pointerTestName + "." + name + " value is " + value + ".");
         }
     });
 
 
     // Check the pressure value