Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11, a=RyanVM
authorJohann Hofmann <jhofmann@mozilla.com>
Fri, 30 Aug 2019 10:14:45 +0000
changeset 545302 4b984be98c545f3895df8fe5c708c3acfa44b1fb
parent 545301 988125c1cc0803941ff485d7256e9a9df226ae49
child 545303 cd3c8dcb9c4d29a5398305badaf8793fcf39e55e
push id2145
push userryanvm@gmail.com
push dateTue, 17 Sep 2019 13:14:12 +0000
treeherdermozilla-release@4b984be98c54 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnhnt11, RyanVM
bugs1577324
milestone69.0.1
Bug 1577324 - Always style the error code field in error pages as a link. r=nhnt11, a=RyanVM The way that we're setting this now actually makes it impossible for this not to be a link, AFAICS. Differential Revision: https://phabricator.services.mozilla.com/D44055
browser/themes/shared/aboutNetError.css
--- a/browser/themes/shared/aboutNetError.css
+++ b/browser/themes/shared/aboutNetError.css
@@ -141,23 +141,18 @@ body:not(.neterror) #advancedButton {
 
 #automaticallyReportInFuture {
   cursor: pointer;
   /* Prevent the checkbox from looking super
    * squeezed on small viewports */
   flex-shrink: 0;
 }
 
-#errorCode:not([href]) {
-  color: var(--in-content-page-color);
-  cursor: text;
-  text-decoration: none;
-}
-
-#errorCode[href] {
+#errorCode {
+  cursor: pointer;
   white-space: nowrap;
 }
 
 #viewCertificate {
   margin: 0 3em;
 }
 
 #badCertTechnicalInfo {
@@ -264,14 +259,14 @@ body:not(.neterror) #advancedButton {
   #badCertTechnicalInfo {
     margin: 10px 10px 5px;
   }
 
   #viewCertificate {
     margin: 0 10px;
   }
 
-  #errorCode[href] {
+  #errorCode {
     /* Break the error code to avoid long codes overflowing the screen */
     white-space: normal;
     word-wrap: anywhere;
   }
 }