Bug 1434888 - Set accessibility panel command key to Shift + F10. r=gl, a=RyanVM, l10n=flod
authorYura Zenevich <yura.zenevich@gmail.com>
Mon, 10 Dec 2018 20:43:49 +0000
changeset 508987 4a9792ce63e3011e473b9d33afdc686bdf47dec0
parent 508986 405ee85a224774b173f440cf225f37108073c0ac
child 508988 aea4a31fb8bb43243c5e6eaa891958b1d803d95a
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl, RyanVM
bugs1434888
milestone65.0
Bug 1434888 - Set accessibility panel command key to Shift + F10. r=gl, a=RyanVM, l10n=flod Differential Revision: https://phabricator.services.mozilla.com/D14095
devtools/client/definitions.js
devtools/client/locales/en-US/startup.properties
devtools/startup/devtools-startup.js
devtools/startup/locales/en-US/key-shortcuts.properties
--- a/devtools/client/definitions.js
+++ b/devtools/client/definitions.js
@@ -407,17 +407,18 @@ Tools.accessibility = {
   ordinal: 14,
   modifiers: osString == "Darwin" ? "accel,alt" : "accel,shift",
   visibilityswitch: "devtools.accessibility.enabled",
   icon: "chrome://devtools/skin/images/tool-accessibility.svg",
   url: "chrome://devtools/content/accessibility/index.html",
   label: l10n("accessibility.label"),
   panelLabel: l10n("accessibility.panelLabel"),
   get tooltip() {
-    return l10n("accessibility.tooltip2");
+    return l10n("accessibility.tooltip3",
+                "Shift+" + functionkey(l10n("accessibility.commandkey")));
   },
   inMenu: true,
 
   isTargetSupported(target) {
     return target.hasActor("accessibility");
   },
 
   build(iframeWindow, toolbox) {
--- a/devtools/client/locales/en-US/startup.properties
+++ b/devtools/client/locales/en-US/startup.properties
@@ -257,21 +257,21 @@ accessibility.label=Accessibility
 # LOCALIZATION NOTE (accessibility.panelLabel):
 # This is used as the label for the toolbox panel.
 accessibility.panelLabel=Accessibility Panel
 
 # LOCALIZATION NOTE (accessibility.accesskey)
 # Used for the menuitem in the tool menu
 accessibility.accesskey=y
 
-# LOCALIZATION NOTE (accessibility.tooltip2):
+# LOCALIZATION NOTE (accessibility.tooltip3):
 # This string is displayed in the tooltip of the tab when the Accessibility is
 # displayed inside the developer tools window.
 # Keyboard shortcut for Accessibility panel will be shown inside the brackets.
-accessibility.tooltip2=Accessibility
+accessibility.tooltip3=Accessibility (%S)
 
 # LOCALIZATION NOTE (application.label):
 # This string is displayed in the title of the tab when the Application panel
 # is displayed inside the developer tools window and in the Developer Tools Menu.
 application.label=Application
 
 # LOCALIZATION NOTE (application.panelLabel):
 # This is used as the label for the toolbox panel.
--- a/devtools/startup/devtools-startup.js
+++ b/devtools/startup/devtools-startup.js
@@ -165,16 +165,22 @@ XPCOMUtils.defineLazyGetter(this, "KeySh
       modifiers: "shift",
     },
     // Key for opening the DOM Panel
     {
       toolId: "dom",
       shortcut: KeyShortcutsBundle.GetStringFromName("dom.commandkey"),
       modifiers,
     },
+    // Key for opening the Accessibility Panel
+    {
+      toolId: "accessibility",
+      shortcut: KeyShortcutsBundle.GetStringFromName("accessibility.commandkey"),
+      modifiers: "shift",
+    },
   ];
 
   if (isMac) {
     // Add the extra key command for macOS, so you can open the inspector with cmd+shift+C
     // like on Chrome DevTools.
     shortcuts.push({
       id: "inspectorMac",
       shortcut: KeyShortcutsBundle.GetStringFromName("inspector.commandkey"),
--- a/devtools/startup/locales/en-US/key-shortcuts.properties
+++ b/devtools/startup/locales/en-US/key-shortcuts.properties
@@ -56,8 +56,12 @@ performance.commandkey=VK_F5
 
 # LOCALIZATION NOTE (storage.commandkey):
 # Key pressed to open a toolbox with the storage panel selected
 storage.commandkey=VK_F9
 
 # LOCALIZATION NOTE (dom.commandkey):
 # Key pressed to open a toolbox with the DOM panel selected
 dom.commandkey=W
+
+# LOCALIZATION NOTE (accessibility.commandkey):
+# Key pressed to open a toolbox with the accessibility panel selected
+accessibility.commandkey=VK_F10