Bug 1493458 - Disable an intermittently failing part of SetCapacity tests. r=erahm
authorHenri Sivonen <hsivonen@hsivonen.fi>
Wed, 28 Nov 2018 17:20:33 +0000
changeset 507761 4990602fac5a62a88da5523d53c5465377c4e05f
parent 507760 8c72e35255c51ce9a67d9767c5d68ed91f3afa1b
child 507762 641de22d6480c8656b5dc6371c57f8b666771c19
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerserahm
bugs1493458
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1493458 - Disable an intermittently failing part of SetCapacity tests. r=erahm Differential Revision: https://phabricator.services.mozilla.com/D13230
xpcom/tests/gtest/TestStrings.cpp
--- a/xpcom/tests/gtest/TestStrings.cpp
+++ b/xpcom/tests/gtest/TestStrings.cpp
@@ -1435,21 +1435,25 @@ TEST_F(Strings, huge_capacity)
     EXPECT_TRUE(i.SetCapacity(nsString::size_type(-1)/4 - 1000, fallible));
     EXPECT_FALSE(i.SetCapacity(nsString::size_type(-1)/4 + 1, fallible));
     i.Truncate();
 
     EXPECT_TRUE(j.SetCapacity(nsString::size_type(-1)/4 - 1000, fallible));
     EXPECT_FALSE(j.SetCapacity(nsString::size_type(-1)/4 + 1, fallible));
     j.Truncate();
 
+// Disabled due to intermittent failures.
+// https://bugzilla.mozilla.org/show_bug.cgi?id=1493458
+#if 0
     EXPECT_TRUE(k.SetCapacity(nsString::size_type(-1)/8 - 1000, fallible));
     EXPECT_TRUE(k.SetCapacity(nsString::size_type(-1)/4 - 1001, fallible));
     EXPECT_TRUE(k.SetCapacity(nsString::size_type(-1)/4 - 998, fallible));
     EXPECT_FALSE(k.SetCapacity(nsString::size_type(-1)/4 + 1, fallible));
     k.Truncate();
+#endif
 
     EXPECT_TRUE(l.SetCapacity(nsString::size_type(-1)/8, fallible));
     EXPECT_TRUE(l.SetCapacity(nsString::size_type(-1)/8 + 1, fallible));
     EXPECT_TRUE(l.SetCapacity(nsString::size_type(-1)/8 + 2, fallible));
     l.Truncate();
 
     EXPECT_TRUE(m.SetCapacity(nsString::size_type(-1)/8 + 1000, fallible));
     EXPECT_TRUE(m.SetCapacity(nsString::size_type(-1)/8 + 1001, fallible));