Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku
authorBen Kelly <ben@wanderview.com>
Thu, 18 Aug 2016 07:11:04 -0700
changeset 353619 493fdcb41ed57ca1559b93b3295930a8708acd44
parent 353618 37b2a40ca3f7dc39abbca5f444a5607914d34eec
child 353620 c0c8cd41219cc42bb78bfc8df52512e1a84e7680
push id1324
push usermtabara@mozilla.com
push dateMon, 16 Jan 2017 13:07:44 +0000
treeherdermozilla-release@a01c49833940 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1293690
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1293690 P3 Force all callers of HoldWorker to provide an explicit status code that triggers failure. r=baku
dom/workers/WorkerHolder.h
--- a/dom/workers/WorkerHolder.h
+++ b/dom/workers/WorkerHolder.h
@@ -72,18 +72,17 @@ enum Status
 class WorkerHolder
 {
 public:
   NS_DECL_OWNINGTHREAD
 
   WorkerHolder();
   virtual ~WorkerHolder();
 
-  bool HoldWorker(WorkerPrivate* aWorkerPrivate,
-                  Status aFailStatus = Canceling);
+  bool HoldWorker(WorkerPrivate* aWorkerPrivate, Status aFailStatus);
   void ReleaseWorker();
 
   virtual bool Notify(Status aStatus) = 0;
 
 protected:
   void ReleaseWorkerInternal();
 
   WorkerPrivate* MOZ_NON_OWNING_REF mWorkerPrivate;