No Bug - Fix up some function names that appear in comments; r=meow
authorTerrence Cole <terrence@mozilla.com>
Fri, 22 Jul 2016 10:50:26 -0700
changeset 348489 492da4127b841cfe2bebdde841c350e6f009c763
parent 348488 d09b4de9752798fb3517826a7ef77bc6cb33761b
child 348490 820961ff0369ddab74419085c64fac957d1be0b3
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmeow
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No Bug - Fix up some function names that appear in comments; r=meow
js/public/Class.h
js/src/jsapi.h
js/src/jspubtd.h
js/src/tests/js1_7/extensions/regress-387955-01.js
js/src/tests/js1_7/extensions/regress-387955-02.js
--- a/js/public/Class.h
+++ b/js/public/Class.h
@@ -376,18 +376,18 @@ struct JSStringFinalizer {
  */
 typedef bool
 (* JSHasInstanceOp)(JSContext* cx, JS::HandleObject obj, JS::MutableHandleValue vp,
                     bool* bp);
 
 /**
  * Function type for trace operation of the class called to enumerate all
  * traceable things reachable from obj's private data structure. For each such
- * thing, a trace implementation must call one of the JS_Call*Tracer variants
- * on the thing.
+ * thing, a trace implementation must call JS::TraceEdge on the thing's
+ * location.
  *
  * JSTraceOp implementation can assume that no other threads mutates object
  * state. It must not change state of the object or corresponding native
  * structures. The only exception for this rule is the case when the embedding
  * needs a tight integration with GC. In that case the embedding can check if
  * the traversal is a part of the marking phase through calling
  * JS_IsGCMarkingTracer and apply a special code like emptying caches or
  * marking its native structures.
--- a/js/src/jsapi.h
+++ b/js/src/jsapi.h
@@ -1587,17 +1587,17 @@ JS_strdup(JSContext* cx, const char* s);
 /** Duplicate a string.  Does not report an error on failure. */
 extern JS_PUBLIC_API(char*)
 JS_strdup(JSRuntime* rt, const char* s);
 
 /**
  * Register externally maintained GC roots.
  *
  * traceOp: the trace operation. For each root the implementation should call
- *          JS_CallTracer whenever the root contains a traceable thing.
+ *          JS::TraceEdge whenever the root contains a traceable thing.
  * data:    the data argument to pass to each invocation of traceOp.
  */
 extern JS_PUBLIC_API(bool)
 JS_AddExtraGCRootsTracer(JSContext* cx, JSTraceDataOp traceOp, void* data);
 
 /** Undo a call to JS_AddExtraGCRootsTracer. */
 extern JS_PUBLIC_API(void)
 JS_RemoveExtraGCRootsTracer(JSContext* cx, JSTraceDataOp traceOp, void* data);
--- a/js/src/jspubtd.h
+++ b/js/src/jspubtd.h
@@ -113,18 +113,18 @@ class JSFlatString;
 typedef struct PRCallOnceType   JSCallOnceType;
 typedef bool                    (*JSInitCallback)(void);
 
 template<typename T> struct JSConstScalarSpec;
 typedef JSConstScalarSpec<double> JSConstDoubleSpec;
 typedef JSConstScalarSpec<int32_t> JSConstIntegerSpec;
 
 /*
- * Generic trace operation that calls JS_CallTracer on each traceable thing
- * stored in data.
+ * Generic trace operation that calls JS::TraceEdge on each traceable thing's
+ * location reachable from data.
  */
 typedef void
 (* JSTraceDataOp)(JSTracer* trc, void* data);
 
 namespace js {
 namespace gc {
 class AutoTraceSession;
 class StoreBuffer;
--- a/js/src/tests/js1_7/extensions/regress-387955-01.js
+++ b/js/src/tests/js1_7/extensions/regress-387955-01.js
@@ -1,17 +1,17 @@
 /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 
 //-----------------------------------------------------------------------------
 var BUGNUMBER = 387955;
-var summary = 'Do not Crash [@ JS_CallTracer]';
+var summary = 'Do not Crash [@ TraceEdge]';
 var actual = 'No Crash';
 var expect = 'No Crash';
 
 //-----------------------------------------------------------------------------
 test();
 //-----------------------------------------------------------------------------
 
 function test()
--- a/js/src/tests/js1_7/extensions/regress-387955-02.js
+++ b/js/src/tests/js1_7/extensions/regress-387955-02.js
@@ -1,17 +1,17 @@
 /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 
 //-----------------------------------------------------------------------------
 var BUGNUMBER = 387955;
-var summary = 'Do not Crash [@ JS_CallTracer]';
+var summary = 'Do not Crash [@ TraceEdge]';
 var actual = 'No Crash';
 var expect = 'No Crash';
 
 //-----------------------------------------------------------------------------
 test();
 //-----------------------------------------------------------------------------
 
 function test()