Backed out 5 changesets (bug 1496220) for chrome failure at toolkit/content/tests/chrome/test_findbar_events.xul. on a CLOSED TREE
authorDaniel Varga <dvarga@mozilla.com>
Wed, 17 Oct 2018 20:21:16 +0300
changeset 500173 47e77fc9d69909cf7454bc58f5ef8189bb6f847d
parent 500172 7fc565646f9fdfb475b2be610739c44f2cb5effb
child 500174 29ccb9942a39045f8d9f7f35d894678a7c2c8e1c
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1496220
milestone64.0a1
backs out2c1353f4a3f554a95bcf73521b05ef4c0335f6e0
bc592bed0522e528eb713f24a639be4c299eb715
7b5505d44965fd3b0719610c52a827c89a6081db
670b75f8446faa1b7368442f142b685288cc7bb8
c4a8a6256d7f800bd2d592bc6467bcfef5cd9309
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 5 changesets (bug 1496220) for chrome failure at toolkit/content/tests/chrome/test_findbar_events.xul. on a CLOSED TREE Backed out changeset 2c1353f4a3f5 (bug 1496220) Backed out changeset bc592bed0522 (bug 1496220) Backed out changeset 7b5505d44965 (bug 1496220) Backed out changeset 670b75f8446f (bug 1496220) Backed out changeset c4a8a6256d7f (bug 1496220)
browser/components/payments/content/paymentDialogWrapper.js
devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
mobile/android/geckoview/src/androidTest/assets/www/newSession.html
mobile/android/modules/geckoview/GeckoViewNavigation.jsm
toolkit/components/remotebrowserutils/RemoteWebNavigation.js
toolkit/content/tests/chrome/bug304188_window.xul
toolkit/content/tests/chrome/bug360437_window.xul
toolkit/content/tests/chrome/findbar_entireword_window.xul
toolkit/content/tests/chrome/findbar_window.xul
--- a/browser/components/payments/content/paymentDialogWrapper.js
+++ b/browser/components/payments/content/paymentDialogWrapper.js
@@ -211,19 +211,17 @@ var paymentDialogWrapper = {
     this.mm.addMessageListener("paymentContentToChrome", this);
     this.mm.loadFrameScript("chrome://payments/content/paymentDialogFrameScript.js", true);
     // Until we have bug 1446164 and bug 1407418 we use form autofill's temporary
     // shim for data-localization* attributes.
     this.mm.loadFrameScript("chrome://formautofill/content/l10n.js", true);
     if (AppConstants.platform == "win") {
       this.frame.setAttribute("selectmenulist", "ContentSelectDropdown-windows");
     }
-    this.frame.loadURI("resource://payments/paymentRequest.xhtml",
-                       { triggeringPrincipal:
-                           Services.scriptSecurityManager.getSystemPrincipal() });
+    this.frame.loadURI("resource://payments/paymentRequest.xhtml");
 
     this.temporaryStore = {
       addresses: new TempCollection("addresses"),
       creditCards: new TempCollection("creditCards"),
     };
   },
 
   createShowResponse({
--- a/devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
+++ b/devtools/shared/heapsnapshot/tests/mochitest/test_saveHeapSnapshot_e10s_01.html
@@ -38,18 +38,17 @@ Bug 1201597 - Sanity test that we can ta
     // Kick everything off on load.
     window.onload = function() {
       info("window.onload fired");
       SpecialPowers.addPermission("browser", true, document);
       SpecialPowers.pushPrefEnv({
          "set": [
              ["dom.ipc.browser_frames.oop_by_default", true],
              ["dom.mozBrowserFramesEnabled", true],
-             ["browser.pagethumbnails.capturing_disabled", true],
-             ["network.disable.ipc.security", true],
+             ["browser.pagethumbnails.capturing_disabled", true]
          ]
       }, function() {
         const iframe = document.createElement("iframe");
         SpecialPowers.wrap(iframe).mozbrowser = true;
         iframe.id = "iframe";
         iframe.src = childFrameURL;
 
         iframe.addEventListener("mozbrowserloadend", function() {
--- a/mobile/android/geckoview/src/androidTest/assets/www/newSession.html
+++ b/mobile/android/geckoview/src/androidTest/assets/www/newSession.html
@@ -1,7 +1,7 @@
 <html>
     <head><title>Hello, world!</title></head>
     <body>
         <a id="targetBlankLink" target="_blank" href="newSession_child.html">target="_blank"</a>
-        <a id="noOpenerLink" target="_blank" rel="noopener" href="http://example.com">rel="noopener"</a>
+        <a id="noOpenerLink" target="_blank" rel="noopener" href="newSession_child.html">rel="noopener"</a>
     </body>
 </html>
--- a/mobile/android/modules/geckoview/GeckoViewNavigation.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewNavigation.jsm
@@ -68,35 +68,19 @@ class GeckoViewNavigation extends GeckoV
         if (flags & (1 << 2)) {
           navFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_EXTERNAL;
         }
 
         if (flags & (1 << 3)) {
           navFlags |= Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_POPUPS;
         }
 
-        let parsedUri;
-        let triggeringPrincipal;
-        try {
-            parsedUri = Services.io.newURI(uri);
-            if (parsedUri.schemeIs("about") || parsedUri.schemeIs("data") ||
-                parsedUri.schemeIs("file") || parsedUri.schemeIs("resource")) {
-              // Only allow privileged loading for certain URIs.
-              triggeringPrincipal = Services.scriptSecurityManager.getSystemPrincipal();
-            }
-        } catch (ignored) {
-        }
-        if (!triggeringPrincipal) {
-          triggeringPrincipal = Services.scriptSecurityManager.createNullPrincipal({});
-        }
-
-        this.browser.loadURI(parsedUri ? parsedUri.spec : uri, {
+        this.browser.loadURI(uri, {
           flags: navFlags,
           referrerURI: referrer,
-          triggeringPrincipal,
         });
         break;
       case "GeckoView:Reload":
         this.browser.reload();
         break;
       case "GeckoView:Stop":
         this.browser.stop();
         break;
--- a/toolkit/components/remotebrowserutils/RemoteWebNavigation.js
+++ b/toolkit/components/remotebrowserutils/RemoteWebNavigation.js
@@ -60,22 +60,20 @@ RemoteWebNavigation.prototype = {
     this._sendMessage("WebNavigation:GoBack", {});
   },
   goForward() {
     this._sendMessage("WebNavigation:GoForward", {});
   },
   gotoIndex(aIndex) {
     this._sendMessage("WebNavigation:GotoIndex", {index: aIndex});
   },
-  loadURI(aURI, aLoadFlags, aReferrer, aPostData, aHeaders,
-          aTriggeringPrincipal) {
+  loadURI(aURI, aLoadFlags, aReferrer, aPostData, aHeaders) {
     this.loadURIWithOptions(aURI, aLoadFlags, aReferrer,
                             Ci.nsIHttpChannel.REFERRER_POLICY_UNSET,
-                            aPostData, aHeaders, null,
-                            aTriggeringPrincipal);
+                            aPostData, aHeaders, null);
   },
   loadURIWithOptions(aURI, aLoadFlags, aReferrer, aReferrerPolicy,
                      aPostData, aHeaders, aBaseURI, aTriggeringPrincipal) {
     // We know the url is going to be loaded, let's start requesting network
     // connection before the content process asks.
     // Note that we might have already setup the speculative connection in some
     // cases, especially when the url is from location bar or its popup menu.
     if (aURI.startsWith("http:") || aURI.startsWith("https:")) {
@@ -102,18 +100,19 @@ RemoteWebNavigation.prototype = {
     this._sendMessage("WebNavigation:LoadURI", {
       uri: aURI,
       flags: aLoadFlags,
       referrer: aReferrer ? aReferrer.spec : null,
       referrerPolicy: aReferrerPolicy,
       postData: aPostData ? Utils.serializeInputStream(aPostData) : null,
       headers: aHeaders ? Utils.serializeInputStream(aHeaders) : null,
       baseURI: aBaseURI ? aBaseURI.spec : null,
-      triggeringPrincipal: Utils.serializePrincipal(
-          aTriggeringPrincipal || Services.scriptSecurityManager.createNullPrincipal({})),
+      triggeringPrincipal: aTriggeringPrincipal
+                           ? Utils.serializePrincipal(aTriggeringPrincipal)
+                           : Services.scriptSecurityManager.createNullPrincipal({}),
       requestTime: Services.telemetry.msSystemNow(),
     });
   },
   setOriginAttributesBeforeLoading(aOriginAttributes) {
     this._sendMessage("WebNavigation:SetOriginAttributes", {
       originAttributes: aOriginAttributes,
     });
   },
--- a/toolkit/content/tests/chrome/bug304188_window.xul
+++ b/toolkit/content/tests/chrome/bug304188_window.xul
@@ -47,18 +47,17 @@ find-menu appears in editor element whic
       let promise = ContentTask.spawn(gBrowser, null, async function() {
         return new Promise(resolve => {
           addEventListener("DOMContentLoaded", function listener() {
             removeEventListener("DOMContentLoaded", listener);
             resolve();
           });
         });
       });
-      gBrowser.loadURI("data:text/html;charset=utf-8,some%20random%20text",
-                       { triggeringPrincipal: window.document.nodePrincipal });
+      gBrowser.loadURI("data:text/html;charset=utf-8,some%20random%20text");
       await promise;
       await onDocumentLoaded();
     }
 
     async function onDocumentLoaded() {
       await ContentTask.spawn(gBrowser, null, async function() {
         var edsession = content.docShell.editingSession;
         edsession.makeWindowEditable(content, "html", false, true, false);
--- a/toolkit/content/tests/chrome/bug360437_window.xul
+++ b/toolkit/content/tests/chrome/bug360437_window.xul
@@ -47,18 +47,17 @@
       let promise = ContentTask.spawn(gBrowser, null, async function() {
         return new Promise(resolve => {
           addEventListener("DOMContentLoaded", function listener() {
             removeEventListener("DOMContentLoaded", listener);
             resolve();
           });
         });
       });
-      gBrowser.loadURI("data:text/html,<form><input id='input' type='text' value='text inside an input element'></form>",
-                       { triggeringPrincipal: window.document.nodePrincipal });
+      gBrowser.loadURI("data:text/html,<form><input id='input' type='text' value='text inside an input element'></form>");
       await promise;
       await onDocumentLoaded();
     }
 
     async function onDocumentLoaded() {
       gFindBar.onFindCommand();
 
       // Make sure the findfield is correctly focused on open
--- a/toolkit/content/tests/chrome/findbar_entireword_window.xul
+++ b/toolkit/content/tests/chrome/findbar_entireword_window.xul
@@ -127,18 +127,17 @@
       let promise = ContentTask.spawn(gBrowser, null, async function() {
         return new Promise(resolve => {
           addEventListener("DOMContentLoaded", function listener() {
             removeEventListener("DOMContentLoaded", listener);
             resolve();
           });
         });
       });
-      gBrowser.loadURI(kBaseURL + "/sample_entireword_" + testName + ".html",
-                       { triggeringPrincipal: window.document.nodePrincipal });
+      gBrowser.loadURI(kBaseURL + "/sample_entireword_" + testName + ".html");
       await promise;
       await onDocumentLoaded(testName);
     }
 
     async function onDocumentLoaded(testName) {
       let suite = kTests[testName];
       await testSimpleEntireWord(suite.testSimpleEntireWord);
       await testCaseSensitive(suite.testCaseSensitive);
--- a/toolkit/content/tests/chrome/findbar_window.xul
+++ b/toolkit/content/tests/chrome/findbar_window.xul
@@ -86,18 +86,17 @@
       gFindBar.browser = gBrowser;
 
       // Tests delays the loading of a document for one second.
       await new Promise(resolve => setTimeout(resolve, 1000));
 
       let promise = BrowserTestUtils.browserLoaded(gBrowser);
       gBrowser.loadURI("data:text/html,<h2 id='h2'>" + SEARCH_TEXT +
         "</h2><h2><a href='" + SAMPLE_URL + "'>Link Test</a></h2><input id='text' type='text' value='" +
-        SAMPLE_TEXT + "'></input><input id='button' type='button'></input><img id='img' width='50' height='50'/>",
-        { triggeringPrincipal: window.document.nodePrincipal });
+        SAMPLE_TEXT + "'></input><input id='button' type='button'></input><img id='img' width='50' height='50'/>");
       await promise;
       await onDocumentLoaded();
     }
 
     async function onDocumentLoaded() {
       await testNormalFind();
       gFindBar.close();
       ok(gFindBar.hidden, "Failed to close findbar after testNormalFind");