Bug 1578489 - New Windows installer icon. r=agashlin a=lizzard
☠☠ backed out by 2f8e434edfbe ☠ ☠
authorMatt Howell <mhowell@mozilla.com>
Mon, 30 Sep 2019 12:54:37 +0300
changeset 555403 47397a99bd0a0ed8360f60fbd6ebb969d7bc7703
parent 555402 ab1a2e4cbda57c895193994ce83d41df603eb69d
child 555404 8a079c3ff32f147fa864990e6fcf9b79efcf27c3
push id2165
push userffxbld-merge
push dateMon, 14 Oct 2019 16:30:58 +0000
treeherdermozilla-release@0eae18af659f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersagashlin, lizzard
bugs1578489
milestone70.0
Bug 1578489 - New Windows installer icon. r=agashlin a=lizzard Summary: This patch includes: * The new icon file itself * A modified Win32 SFX binary with the icon resource replaced and no other changes * A rebuilt ARM64 binary (because rebuilding it is just as easy as resource hacking it) * And I also took the opportunity to update the VC project to the 2019 toolchain and removed the requirement for a particular Windows 10 SDK version. Reviewers: agashlin Reviewed By: agashlin Bug #: 1578489 Differential Revision: https://phabricator.services.mozilla.com/D46846
other-licenses/7zstub/firefox/7zSD.ARM64.sfx
other-licenses/7zstub/firefox/7zSD.Win32.sfx
other-licenses/7zstub/firefox/SFXSetup.vcxproj
other-licenses/7zstub/firefox/setup.ico
index 1d962b4e10d1b085a2b0b258f133015647bedafd..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
index 9cb1d5645fdae4cab35cc416c67c3da0108e6d8b..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
--- a/other-licenses/7zstub/firefox/SFXSetup.vcxproj
+++ b/other-licenses/7zstub/firefox/SFXSetup.vcxproj
@@ -17,40 +17,40 @@
       <Configuration>ReleaseD</Configuration>
       <Platform>Win32</Platform>
     </ProjectConfiguration>
   </ItemGroup>
   <PropertyGroup Label="Globals">
     <SccProjectName />
     <SccLocalPath />
     <ProjectGuid>{B348342A-1787-4311-B120-EDAE3018868F}</ProjectGuid>
-    <WindowsTargetPlatformVersion>10.0.17763.0</WindowsTargetPlatformVersion>
+    <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
-    <PlatformToolset>v141</PlatformToolset>
+    <PlatformToolset>v142</PlatformToolset>
     <UseOfMfc>false</UseOfMfc>
     <CharacterSet>Unicode</CharacterSet>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
-    <PlatformToolset>v141</PlatformToolset>
+    <PlatformToolset>v142</PlatformToolset>
     <UseOfMfc>false</UseOfMfc>
     <CharacterSet>Unicode</CharacterSet>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='ReleaseD|Win32'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
-    <PlatformToolset>v141</PlatformToolset>
+    <PlatformToolset>v142</PlatformToolset>
     <UseOfMfc>false</UseOfMfc>
     <CharacterSet>Unicode</CharacterSet>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='ReleaseD|ARM64'" Label="Configuration">
     <ConfigurationType>Application</ConfigurationType>
-    <PlatformToolset>v141</PlatformToolset>
+    <PlatformToolset>v142</PlatformToolset>
     <UseOfMfc>false</UseOfMfc>
     <CharacterSet>Unicode</CharacterSet>
   </PropertyGroup>
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
   <ImportGroup Label="ExtensionSettings">
   </ImportGroup>
   <ImportGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="PropertySheets">
     <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
index 794f23d5c06c37d64ac0d2f8909a7b17adcb8289..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001