Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme r=dao a=jcristau
authorKestrel <ke5trel@protonmail.com>
Mon, 27 May 2019 09:17:15 +0000
changeset 536773 46f0e514450cd34e77ecb0c337cda47305a6273e
parent 536772 039662b2b76c2d7c0ae4ca537d4501a107c4b2f7
child 536774 341cf2990acb03ec601d64db134bcf3243961cd4
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao, jcristau
bugs1539379
milestone68.0
Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme r=dao a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D32673
browser/themes/windows/compacttheme.css
--- a/browser/themes/windows/compacttheme.css
+++ b/browser/themes/windows/compacttheme.css
@@ -28,21 +28,16 @@
 
 @media (-moz-os-version: windows-win7) {
   @media (-moz-windows-default-theme) {
     /* Always show light toolbar elements on aero surface. */
     #TabsToolbar {
       color: hsl(240,9%,98%);
     }
 
-    /* Keep showing the correct color inside the tabs. */
-    .tabbrowser-tab {
-      color: var(--lwt-text-color) !important;
-    }
-
     /* Because we're forcing the tabs toolbar to be [brighttext] to
      * get white toolbar button icons, we need to manually set the
      * correct color for the tab hover state for the light theme. */
     .tabbrowser-tab:hover > .tab-stack > .tab-background:not([selected=true]):not([multiselected]):-moz-lwtheme-darktext {
       background-color: rgba(0,0,0,.1) !important;
     }
     .tabbrowser-tab:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]):not([multiselected]):-moz-lwtheme-darktext {
       background-color: rgba(0,0,0,.2) !important;
@@ -88,16 +83,17 @@
   .tabbrowser-tab::after {
     border-image: none !important;
   }
 
   /* Show border on tabs with background colors and
    * show the tabs toolbar background color inside tabs. */
   .tabbrowser-tab {
     background-color: var(--lwt-accent-color) !important;
+    color: var(--lwt-text-color) !important;
     border-top: 1px solid var(--tabs-border-color);
     background-clip: padding-box;
   }
 
   /* The top border on top of the tab background is replaced
    * by the slightly transparent outside tabs-border-color. */
   .tab-background {
     border-top-style: none !important;