Bug 1173357 - Use the default application association dialog on Windows 8.1 and earlier when setting the default browser through the Preferences. r=Gijs, a=lizzard
authorJared Wein <jwein@mozilla.com>
Thu, 11 Jun 2015 12:20:38 -0400
changeset 267758 44d2a7b1ca964397e0abc42d6f20c8854ddc07bb
parent 267757 b15795eeab4a75667d1b8fae49532adc38a13333
child 267759 36b1d114889658d52192a35b2d137819a6aa1408
push id830
push userraliiev@mozilla.com
push dateFri, 19 Jun 2015 19:24:37 +0000
treeherdermozilla-release@932614382a68 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, lizzard
bugs1173357
milestone39.0
Bug 1173357 - Use the default application association dialog on Windows 8.1 and earlier when setting the default browser through the Preferences. r=Gijs, a=lizzard
browser/components/preferences/in-content/main.js
--- a/browser/components/preferences/in-content/main.js
+++ b/browser/components/preferences/in-content/main.js
@@ -705,22 +705,24 @@ var gMainPane = {
     * such as Windows have terrible UIs for all filetypes. In those
     * platforms, Firefox only attempts to associate itself with HTML.
     */
    shouldClaimAllTypes: function()
    {
     let claimAllTypes = true;
     try {
       if (AppConstants.platform == "win") {
-        // In Windows 8+, the UI for selecting default protocol is much
+        // In Windows 10+, the UI for selecting default protocol is much
         // nicer than the UI for setting file type associations. So we
-        // only show the protocol association screen on Windows 8+.
-        // Windows 8 is version 6.2.
+        // only show the protocol association screen on Windows 10+.
+        // Windows 8.1 is version 6.3. The startup code still uses
+        // the default protocol dialog, but the preferences is more "advanced"
+        // and as such uses the file type associations.
         let version = Services.sysinfo.getProperty("version");
-        claimAllTypes = (parseFloat(version) < 6.2);
+        claimAllTypes = (parseFloat(version) <= 6.3);
       }
     } catch (ex) {}
     return claimAllTypes;
    },
 
   /**
    * Show button for setting browser as default browser or information that
    * browser is already the default browser.