Bug 1524335: Make InOrderPacket take last_sequence_number by reference; r=dmajor a=lizzard
authorDan Minor <dminor@mozilla.com>
Wed, 13 Feb 2019 13:05:20 -0500
changeset 515976 448d348e474bba880ad0f8bdce67943bc23604e9
parent 515975 f222bec68b2672907576a15518af61e8bd6de88d
child 515977 14f5f0ae70f466bcdba4bae0878f93557fbcf17e
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor, lizzard
bugs1524335
milestone66.0
Bug 1524335: Make InOrderPacket take last_sequence_number by reference; r=dmajor a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19694
media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
--- a/media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
+++ b/media/webrtc/trunk/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
@@ -24,17 +24,17 @@
 #include "modules/rtp_rtcp/include/rtp_payload_registry.h"
 #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
 #include "modules/rtp_rtcp/source/rtp_receiver_strategy.h"
 #include "rtc_base/logging.h"
 
 namespace webrtc {
 
 namespace {
-bool InOrderPacket(rtc::Optional<uint16_t> latest_sequence_number,
+bool InOrderPacket(const rtc::Optional<uint16_t>& latest_sequence_number,
                    uint16_t current_sequence_number) {
   if (!latest_sequence_number)
     return true;
 
   // We need to distinguish between a late or retransmitted packet,
   // and a sequence number discontinuity.
   if (IsNewerSequenceNumber(current_sequence_number, *latest_sequence_number)) {
     return true;