Bug 1550402 - Remove unnecessary return nullptr in ShmemTextureData::Create() r=nical
authorsotaro <sotaro.ikeda.g@gmail.com>
Thu, 09 May 2019 07:36:40 +0000
changeset 535447 441e225e25eb16f655ca20745168da240de9f9e4
parent 535446 cb00aa26b3484a2fd795facb8d5df24d2249c64f
child 535448 02b3eb8a1a1388f91c73cce582ce1e2b972f11f7
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1550402
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550402 - Remove unnecessary return nullptr in ShmemTextureData::Create() r=nical The "return nullptr" is redundant. Differential Revision: https://phabricator.services.mozilla.com/D30457
gfx/layers/BufferTexture.cpp
--- a/gfx/layers/BufferTexture.cpp
+++ b/gfx/layers/BufferTexture.cpp
@@ -528,18 +528,16 @@ ShmemTextureData* ShmemTextureData::Crea
 
   bool hasIntermediateBuffer = ComputeHasIntermediateBuffer(
       aFormat, aLayersBackend, aAllocFlags & ALLOC_ALLOW_DIRECT_MAPPING);
 
   BufferDescriptor descriptor =
       RGBDescriptor(aSize, aFormat, hasIntermediateBuffer);
 
   return new ShmemTextureData(descriptor, aMoz2DBackend, shm);
-
-  return nullptr;
 }
 
 TextureData* ShmemTextureData::CreateSimilar(
     LayersIPCChannel* aAllocator, LayersBackend aLayersBackend,
     TextureFlags aFlags, TextureAllocationFlags aAllocFlags) const {
   return ShmemTextureData::Create(GetSize(), GetFormat(), mMoz2DBackend,
                                   aLayersBackend, aFlags, aAllocFlags,
                                   aAllocator);