Bug 1508824 - SharedWorker.onconnect event should be a MessageEvent with an empty string as data, r=asuth
authorAndrea Marchesini <amarchesini@mozilla.com>
Tue, 27 Nov 2018 08:44:47 +0100
changeset 507485 434b3eacae093f3a29d032cd5e964d39fc0175b6
parent 507484 324633b19b6c1c292c2c352f2b87144a4482abef
child 507486 99ae47766ba9732664c0f828126beadb37220be4
push id1905
push userffxbld-merge
push dateMon, 21 Jan 2019 12:33:13 +0000
treeherdermozilla-release@c2fca1944d8c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1508824
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1508824 - SharedWorker.onconnect event should be a MessageEvent with an empty string as data, r=asuth
dom/workers/WorkerPrivate.cpp
testing/web-platform/meta/workers/constructors/SharedWorker/connect-event.html.ini
--- a/dom/workers/WorkerPrivate.cpp
+++ b/dom/workers/WorkerPrivate.cpp
@@ -4952,16 +4952,17 @@ WorkerPrivate::ConnectMessagePort(JSCont
   }
 
   GlobalObject globalObject(aCx, jsGlobal);
   if (globalObject.Failed()) {
     return false;
   }
 
   RootedDictionary<MessageEventInit> init(aCx);
+  init.mData = JS_GetEmptyStringValue(aCx);
   init.mBubbles = false;
   init.mCancelable = false;
   init.mSource.SetValue().SetAsMessagePort() = port;
   if (!init.mPorts.AppendElement(port.forget(), fallible)) {
     return false;
   }
 
   RefPtr<MessageEvent> event =
deleted file mode 100644
--- a/testing/web-platform/meta/workers/constructors/SharedWorker/connect-event.html.ini
+++ /dev/null
@@ -1,4 +0,0 @@
-[connect-event.html]
-  [connect event]
-    expected: FAIL
-