Bug 1502118 - Enforce GV lints with apilint. r=snorp
authorAgi Sferro <agi@mozilla.com>
Mon, 17 Dec 2018 22:32:11 +0000
changeset 511002 42f4f1c36ef6daf56fae1433db40a3116b3dfe9d
parent 511001 4cd3b9cf8159f9b73cfb625dd105eb5cd259395a
child 511003 6e0214071eabc06c35c92b931adcfdb798feb21f
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1502118
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1502118 - Enforce GV lints with apilint. r=snorp This makes it so that apilints lints with "GV" codes are enforced and will fail the build. Depends on D13882 Differential Revision: https://phabricator.services.mozilla.com/D13883
build.gradle
mobile/android/geckoview/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -82,17 +82,17 @@ buildscript {
     ext.support_library_version = '26.1.0'
     ext.jacoco_version = '0.8.1'
 
     if (gradle.mozconfig.substs.MOZ_ANDROID_GOOGLE_PLAY_SERVICES) {
         ext.google_play_services_version = '15.0.1'
     }
 
     dependencies {
-        classpath 'org.mozilla.apilint:apilint:0.1.4'
+        classpath 'org.mozilla.apilint:apilint:0.1.5'
         classpath 'com.android.tools.build:gradle:3.1.4'
         classpath 'com.getkeepsafe.dexcount:dexcount-gradle-plugin:0.8.2'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
     }
 }
 
 if ('multi' == System.env.AB_CD) {
     // Multi-l10n builds set `AB_CD=multi`, which isn't a valid locale.  This
--- a/mobile/android/geckoview/build.gradle
+++ b/mobile/android/geckoview/build.gradle
@@ -488,11 +488,14 @@ if (mozconfig.substs.MOZ_JAVA_CODE_COVER
             // Running multiple variants of this task will overwrite the output archive.
             archiveName = 'target.geckoview_classfiles.zip'
         }
     }
 }
 
 apply plugin: 'org.mozilla.apilint'
 
-// TODO: Change this to `org` after hiding org.mozilla.gecko
-apiLint.packageFilter = 'org.mozilla.geckoview'
-apiLint.changelogFileName = 'CHANGELOG.md'
+apiLint {
+    // TODO: Change this to `org` after hiding org.mozilla.gecko
+    packageFilter = 'org.mozilla.geckoview'
+    changelogFileName = 'CHANGELOG.md'
+    lintFilters = ['GV']
+}