Bug 1208951 - Part 8: Don't warn if StyleAnimationValue::ComputeValue fails to parse a CSS property. r=birtles
authorCameron McCormack <cam@mcc.id.au>
Thu, 22 Oct 2015 19:22:38 +1100
changeset 304133 42e93722947bc51e3804dc1845df31e8535f2336
parent 304132 e7ee6d330e9df46cba717bab81e6cb2c5df8f25d
child 304134 2c8c77ea3a05383c21fe184cb4f2b5136aede1f1
push id1001
push userraliiev@mozilla.com
push dateMon, 18 Jan 2016 19:06:03 +0000
treeherdermozilla-release@8b89261f3ac4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbirtles
bugs1208951
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1208951 - Part 8: Don't warn if StyleAnimationValue::ComputeValue fails to parse a CSS property. r=birtles Since we will call StyleAnimationValue::ComputeValues with values that come from script, we don't want to warn if we have an invalid value.
layout/style/StyleAnimationValue.cpp
--- a/layout/style/StyleAnimationValue.cpp
+++ b/layout/style/StyleAnimationValue.cpp
@@ -2505,17 +2505,16 @@ BuildStyleRule(nsCSSProperty aProperty,
   // Get a parser, parse the property, and check for CSS parsing errors.
   // If this fails, we bail out and delete the declaration.
   parser.ParseProperty(aProperty, aSpecifiedValue, doc->GetDocumentURI(),
                        baseURI, aTargetElement->NodePrincipal(), declaration,
                        &changed, false, aUseSVGMode);
 
   // check whether property parsed without CSS parsing errors
   if (!declaration->HasNonImportantValueFor(propertyToCheck)) {
-    NS_WARNING("failure in BuildStyleRule");
     return nullptr;
   }
 
   RefPtr<css::StyleRule> rule = new css::StyleRule(nullptr,
                                                      declaration.forget(),
                                                      0, 0);
   return rule.forget();
 }