Bug 1551929. Mark some storage interfaces builtinclass, since we assume there are no JS implementations already. r=asuth
authorBoris Zbarsky <bzbarsky@mit.edu>
Thu, 16 May 2019 11:23:44 +0000
changeset 535975 41f28d23024ebecf5445896cd3b6b39a6b650a9d
parent 535974 8c1f903def0c4fae9cf3efb9735df8310404fea9
child 535976 d4bbc018fe902044fb90f08b6dc2c0a0d172423d
push id2082
push userffxbld-merge
push dateMon, 01 Jul 2019 08:34:18 +0000
treeherdermozilla-release@2fb19d0466d2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersasuth
bugs1551929
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1551929. Mark some storage interfaces builtinclass, since we assume there are no JS implementations already. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D31342
storage/mozIStorageAsyncStatement.idl
storage/mozIStorageBaseStatement.idl
storage/mozIStorageStatement.idl
--- a/storage/mozIStorageAsyncStatement.idl
+++ b/storage/mozIStorageAsyncStatement.idl
@@ -11,17 +11,17 @@
  * only being usable for asynchronous execution.  (mozIStorageStatement can
  * be used for both synchronous and asynchronous purposes.)  This specialization
  * for asynchronous operation allows us to avoid needing to acquire
  * synchronization primitives also used by the asynchronous execution thread.
  * In contrast, mozIStorageStatement may need to acquire the primitives and
  * consequently can cause the main thread to lock for extended intervals while
  * the asynchronous thread performs some long-running operation.
  */
-[scriptable, uuid(52e49370-3b2e-4a27-a3fc-79e20ad4056b)]
+[scriptable, builtinclass, uuid(52e49370-3b2e-4a27-a3fc-79e20ad4056b)]
 interface mozIStorageAsyncStatement : mozIStorageBaseStatement {
   /*
    * 'params' provides a magic JS helper that lets you assign parameters by
    * name.  Unlike the helper on mozIStorageStatement, you cannot enumerate
    * in order to find out what parameters are legal.
    *
    * This does not work for BLOBs.  You must use an explicit binding API for
    * that.
--- a/storage/mozIStorageBaseStatement.idl
+++ b/storage/mozIStorageBaseStatement.idl
@@ -14,17 +14,17 @@ interface mozIStorageBindingParams;
 interface mozIStorageBindingParamsArray;
 
 /**
  * The base interface for both pure asynchronous storage statements 
  * (mozIStorageAsyncStatement) and 'classic' storage statements
  * (mozIStorageStatement) that can be used for both synchronous and asynchronous
  * purposes.
  */
-[scriptable, uuid(16ca67aa-1325-43e2-aac7-859afd1590b2)]
+[scriptable, builtinclass, uuid(16ca67aa-1325-43e2-aac7-859afd1590b2)]
 interface mozIStorageBaseStatement : mozIStorageBindingParams {
   /**
    * Finalizes a statement so you can successfully close a database connection.
    * Once a statement has been finalized it can no longer be used for any
    * purpose.
    * 
    * Statements are implicitly finalized when their reference counts hits zero.
    * If you are a native (C++) caller this is accomplished by setting all of
--- a/storage/mozIStorageStatement.idl
+++ b/storage/mozIStorageStatement.idl
@@ -10,17 +10,17 @@
 %}
 
 [ptr] native octetPtr(uint8_t);
 
 /**
  * A SQL statement that can be used for both synchronous and asynchronous
  * purposes.
  */
-[scriptable, uuid(5f567c35-6c32-4140-828c-683ea49cfd3a)]
+[scriptable, builtinclass, uuid(5f567c35-6c32-4140-828c-683ea49cfd3a)]
 interface mozIStorageStatement : mozIStorageBaseStatement {
   /**
    * Create a clone of this statement, by initializing a new statement
    * with the same connection and same SQL statement as this one.  It
    * does not preserve statement state; that is, if a statement is
    * being executed when it is cloned, the new statement will not be
    * executing.
    */