Bug 932335 - Pre 2: make getSizedFaviconFromCache package-private r=me
authorAndrzej Hunt <ahunt@mozilla.com>
Mon, 23 May 2016 14:42:25 -0700
changeset 340673 41b8ce50bc2726cf588680646bae48737f57cf67
parent 340672 14a136ae4655bc17fef1df6ab6e4cf5ccc8ad2d4
child 340674 228556a98ec92b6ca7782e1bd9f8c0dc70aae6a5
push id1183
push userraliiev@mozilla.com
push dateMon, 05 Sep 2016 20:01:49 +0000
treeherdermozilla-release@3148731bed45 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs932335
milestone49.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 932335 - Pre 2: make getSizedFaviconFromCache package-private r=me There's no need for this to be visible app-wide, we're only using this in LoadFaviconTask. MozReview-Commit-ID: EZh8NtRbBMh
mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
--- a/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
+++ b/mobile/android/base/java/org/mozilla/gecko/favicons/Favicons.java
@@ -250,17 +250,17 @@ public class Favicons {
      * null otherwise. Does not query the database or network for the Favicon is the result is not
      * immediately available.
      *
      * @param faviconURL URL of the Favicon to query for.
      * @param targetSize The desired size of the returned Favicon.
      * @return The cached Favicon, rescaled to be as close as possible to the target size, if any exists.
      *         null if no applicable Favicon exists in the cache.
      */
-    public static Bitmap getSizedFaviconFromCache(String faviconURL, int targetSize) {
+    static Bitmap getSizedFaviconFromCache(String faviconURL, int targetSize) {
         return faviconsCache.getFaviconForDimensions(faviconURL, targetSize);
     }
 
     /**
      * Attempts to find a Favicon for the provided page URL from either the mem cache or the database.
      * Does not need an explicit favicon URL, since, as we are accessing the database anyway, we
      * can query the history DB for the Favicon URL.
      * Handy for easing the transition from caching with page URLs to caching with Favicon URLs.