Bug 1516806 - Remove SPDY_VERSION2 telemetry probe. r=kershaw a=lizzard
authorDragana Damjanovic <dd.mozilla@gmail.com>
Fri, 08 Feb 2019 13:16:11 +0000
changeset 516172 4171deeda04bb446358cc6d6c76bd6cf4f0cd45f
parent 516171 20cd9dd27bfc31a54f8451837f941891374d3363
child 516173 524a4774fe51436368c729ab6eebad22072c61a6
push id1953
push userffxbld-merge
push dateMon, 11 Mar 2019 12:10:20 +0000
treeherdermozilla-release@9c35dcbaa899 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskershaw, lizzard
bugs1516806
milestone66.0
Bug 1516806 - Remove SPDY_VERSION2 telemetry probe. r=kershaw a=lizzard Differential Revision: https://phabricator.services.mozilla.com/D19138
netwerk/protocol/http/ASpdySession.cpp
toolkit/components/telemetry/Histograms.json
toolkit/components/telemetry/histogram-whitelists.json
--- a/netwerk/protocol/http/ASpdySession.cpp
+++ b/netwerk/protocol/http/ASpdySession.cpp
@@ -31,19 +31,16 @@ ASpdySession *ASpdySession::NewSpdySessi
   // requests as a precondition
   MOZ_ASSERT(version == SpdyVersion::HTTP_2, "Unsupported spdy version");
 
   // Don't do a runtime check of IsSpdyV?Enabled() here because pref value
   // may have changed since starting negotiation. The selected protocol comes
   // from a list provided in the SERVER HELLO filtered by our acceptable
   // versions, so there is no risk of the server ignoring our prefs.
 
-  Telemetry::Accumulate(Telemetry::SPDY_VERSION2,
-                        static_cast<uint32_t>(version));
-
   return new Http2Session(aTransport, version, attemptingEarlyData);
 }
 
 SpdyInformation::SpdyInformation() {
   // highest index of enabled protocols is the
   // most preferred for ALPN negotiaton
   Version[0] = SpdyVersion::HTTP_2;
   VersionString[0] = NS_LITERAL_CSTRING("h2");
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -2407,24 +2407,16 @@
   },
   "WEBSOCKETS_HANDSHAKE_TYPE": {
     "record_in_processes": ["main", "content"],
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 16,
     "description": "Websockets Handshake Results (ws-ok-plain, ws-ok-proxy, ws-failed-plain, ws-failed-proxy, wss-ok-plain, wss-ok-proxy, wss-failed-plain, wss-failed-proxy)"
   },
-  "SPDY_VERSION2": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["necko@mozilla.com"],
-    "expires_in_version": "never",
-    "kind": "enumerated",
-    "n_values": 48,
-    "description": "SPDY: Protocol Version Used"
-  },
   "HTTP_RESPONSE_VERSION": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["necko@mozilla.com"],
     "expires_in_version": "never",
     "kind": "enumerated",
     "n_values": 48,
     "description": "HTTP: Protocol Version Used on Response from nsHttp.h"
   },
--- a/toolkit/components/telemetry/histogram-whitelists.json
+++ b/toolkit/components/telemetry/histogram-whitelists.json
@@ -1005,17 +1005,16 @@
     "SPDY_REQUEST_PER_CONN",
     "SPDY_SERVER_INITIATED_STREAMS",
     "SPDY_SETTINGS_IW",
     "SPDY_SETTINGS_MAX_STREAMS",
     "SPDY_SYN_RATIO",
     "SPDY_SYN_REPLY_RATIO",
     "SPDY_SYN_REPLY_SIZE",
     "SPDY_SYN_SIZE",
-    "SPDY_VERSION2",
     "SSL_AUTH_ALGORITHM_FULL",
     "SSL_AUTH_ECDSA_CURVE_FULL",
     "SSL_AUTH_RSA_KEY_SIZE_FULL",
     "SSL_BYTES_BEFORE_CERT_CALLBACK",
     "SSL_CERT_ERROR_OVERRIDES",
     "SSL_CIPHER_SUITE_FULL",
     "SSL_CIPHER_SUITE_RESUMED",
     "SSL_HANDSHAKE_TYPE",