Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen a=jcristau
authorMike Conley <mconley@mozilla.com>
Tue, 06 Nov 2018 04:35:00 +0000
changeset 501108 410f4e7ae2feb52dc23db8892829e1b767477849
parent 501107 24ac9d53d202349388e7d35b5bf1934aa76fdc72
child 501109 cd20a71aba8a9f29804c3a848cd12c75750626a7
push id1864
push userffxbld-merge
push dateMon, 03 Dec 2018 15:51:40 +0000
treeherdermozilla-release@f040763d99ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjchen, jcristau
bugs1498233
milestone64.0
Bug 1498233 - Stub out getBrowserForOuterWindowID for GeckoViewTab. r=jchen a=jcristau GeckoViewTab stubs out gBrowser on the root window for WebExtension compatibility. LoginManagerParent also looks for gBrowser on windows that are handling username and password form fills, and expects it to implement getBrowserForOuterWindowID. This patch makes the stub implement getBrowserForOuterWindowID, which just returns the lone GeckoViewTab browser. Differential Revision: https://phabricator.services.mozilla.com/D10750
mobile/android/modules/geckoview/GeckoViewTab.jsm
--- a/mobile/android/modules/geckoview/GeckoViewTab.jsm
+++ b/mobile/android/modules/geckoview/GeckoViewTab.jsm
@@ -40,11 +40,15 @@ class GeckoViewTab extends GeckoViewModu
 
       getTabForWindow: function(aWindow) {
         return this.selectedTab;
       },
 
       getTabForDocument: function(aDocument) {
         return this.selectedTab;
       },
+
+      getBrowserForOuterWindowID: function(aID) {
+        return this.browser;
+      },
     };
   }
 }