Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj, a=RyanVM
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 06 Jun 2018 16:13:09 +0900
changeset 473693 40c975562211ad6c054de920f857457f224b3502
parent 473692 f8c51a29161564cd2f958a36c92bd7f9493776a5
child 473694 05400e59a489907c2efdabb31d747eee56a79905
push id1728
push userjlund@mozilla.com
push dateMon, 18 Jun 2018 21:12:27 +0000
treeherdermozilla-release@c296fde26f5f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj, RyanVM
bugs1467041
milestone61.0
Bug 1467041 - Default to --enable-release when milestone is beta/release. r=froydnj, a=RyanVM --enable-release not being passed means developer options are enabled, which is generally speaking not desirable for builds meant to be shipped. This is somewhat alleviated for Firefox by MOZILLA_OFFICIAL implying --enable-release (as well as MOZ_AUTOMATION), but that doesn't apply to e.g. standalone js builds (even some of the standalone js jobs on our automation don't set MOZ_AUTOMATION for some reason). A reasonable thing to do is just to default builds for release/beta milestones to --enable-release, but still allow --disable-release to enable the developer options.
build/moz.configure/toolchain.configure
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1369,16 +1369,17 @@ option(env='RUSTFLAGS',
        help='Rust compiler flags')
 set_config('RUSTFLAGS', depends('RUSTFLAGS')(lambda flags: flags))
 
 
 imply_option('--enable-release', mozilla_official)
 imply_option('--enable-release', depends_if('MOZ_AUTOMATION')(lambda x: True))
 
 js_option('--enable-release',
+          default=milestone.is_release_or_beta,
           help='Build with more conservative, release engineering-oriented '
                'options. This may slow down builds.')
 
 
 @depends('--enable-release')
 def developer_options(value):
     if not value:
         return True