Bug 1288954 - Only log error if failureId is set. r=jrmuizel
authorBenoit Girard <b56girard@gmail.com>
Sun, 24 Jul 2016 11:11:09 -0400
changeset 348381 3f5a9799b9feabdd49dfd73d03c4bf0e3514ee3b
parent 348380 6fb55e17cd0279ade680b87ad9bc2d03424affc3
child 348382 d5407d5642bf63eef799eedf52052fc9a6074d71
push id1230
push userjlund@mozilla.com
push dateMon, 31 Oct 2016 18:13:35 +0000
treeherdermozilla-release@5e06e3766db2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1288954
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1288954 - Only log error if failureId is set. r=jrmuizel MozReview-Commit-ID: HsjNnHTqaya
gfx/gl/GLLibraryEGL.cpp
--- a/gfx/gl/GLLibraryEGL.cpp
+++ b/gfx/gl/GLLibraryEGL.cpp
@@ -184,16 +184,20 @@ public:
 
     void SetFailureId(nsACString* const aFailureId)
     {
       mFailureId = aFailureId;
     }
 
     void logError(const char *errorMessage) override
     {
+        if (!mFailureId) {
+            return;
+        }
+
         nsCString str(errorMessage);
         Tokenizer tokenizer(str);
 
         // Parse "ANGLE Display::initialize error " << error.getID() << ": "
         //       << error.getMessage()
         nsCString currWord;
         Tokenizer::Token intToken;
         if (tokenizer.CheckWord("ANGLE") &&